You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "hachikuji (via GitHub)" <gi...@apache.org> on 2023/01/20 21:34:48 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #13138: MINOR: Small cleanups in refactored consumer implementation

hachikuji commented on code in PR #13138:
URL: https://github.com/apache/kafka/pull/13138#discussion_r1083069990


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -97,8 +97,8 @@ private void trySend(final long currentTimeMs) {
             unsent.timer.update(currentTimeMs);
             if (unsent.timer.isExpired()) {
                 iterator.remove();
-                unsent.callback.ifPresent(c -> c.onFailure(new TimeoutException(
-                        "Failed to send request after " + unsent.timer.timeoutMs() + " " + "ms.")));
+                unsent.callback.onFailure(new TimeoutException(
+                    "Failed to send request after " + unsent.timer.timeoutMs() + " " + "ms."));

Review Comment:
   Ack. Wil fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org