You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by ss...@apache.org on 2013/01/18 00:13:30 UTC

svn commit: r1434954 - /mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java

Author: ssc
Date: Thu Jan 17 23:13:30 2013
New Revision: 1434954

URL: http://svn.apache.org/viewvc?rev=1434954&view=rev
Log:
MAHOUT-1105 AbstractNaiveBayesClassifier.classifyFull(Vector,Vector) not reusing provided result vector

Modified:
    mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java?rev=1434954&r1=1434953&r2=1434954&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java (original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/AbstractNaiveBayesClassifier.java Thu Jan 17 23:13:30 2013
@@ -55,16 +55,14 @@ public abstract class AbstractNaiveBayes
 
   @Override
   public Vector classifyFull(Vector instance) {
-    Vector score = model.createScoringVector();
-    for (int label = 0; label < model.numLabels(); label++) {
-      score.set(label, getScoreForLabelInstance(label, instance));
-    }
-    return score;
+    return classifyFull(model.createScoringVector(), instance);
   }
   
   @Override
   public Vector classifyFull(Vector r, Vector instance) {
-    r = classifyFull(instance);
+    for (int label = 0; label < model.numLabels(); label++) {
+      r.setQuick(label, getScoreForLabelInstance(label, instance));
+    }
     return r;
   }