You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/11 11:43:16 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request, #10886: [Fix-10827] Fix network error cause worker cannot send message to master
ruanwenjun opened a new pull request, #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886
## Purpose of the pull request
- Rename some command to message, add sourceAddress and targetAddress in message
- When worker send message to master use the separate connection
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181270459
@caishunfeng I have revert the rename change of command, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180629388
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10886](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc5a444) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/aa8b88a875f1abc16c22c7d81c77e31d855a2e21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa8b88a) will **decrease** coverage by `0.01%`.
> The diff coverage is `1.69%`.
> :exclamation: Current head fc5a444 differs from pull request most recent head cbef534. Consider uploading reports for the commit cbef534 to get more accurate results
```diff
@@ Coverage Diff @@
## dev #10886 +/- ##
============================================
- Coverage 40.13% 40.12% -0.02%
+ Complexity 4843 4837 -6
============================================
Files 940 945 +5
Lines 36945 36931 -14
Branches 4033 4039 +6
============================================
- Hits 14828 14817 -11
+ Misses 20630 20619 -11
- Partials 1487 1495 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inscheduler/server/master/config/MasterConfig.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25maWcvTWFzdGVyQ29uZmlnLmphdmE=) | `33.33% <0.00%> (-1.67%)` | :arrow_down: |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...master/dispatch/executor/NettyExecutorManager.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9leGVjdXRvci9OZXR0eUV4ZWN1dG9yTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ler/server/master/event/TaskDelayEventHandler.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ldmVudC9UYXNrRGVsYXlFdmVudEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/master/event/TaskRejectByWorkerEventHandler.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ldmVudC9UYXNrUmVqZWN0QnlXb3JrZXJFdmVudEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...er/server/master/event/TaskResultEventHandler.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ldmVudC9UYXNrUmVzdWx0RXZlbnRIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/server/master/event/TaskRunningEventHandler.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ldmVudC9UYXNrUnVubmluZ0V2ZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...master/processor/TaskExecuteResponseProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVSZXNwb25zZVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../master/processor/TaskExecuteRunningProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVSdW5uaW5nUHJvY2Vzc29yLmphdmE=) | `25.00% <0.00%> (ø)` | |
| [...r/server/master/processor/TaskRecallProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvVGFza1JlY2FsbFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [50 more](https://codecov.io/gh/apache/dolphinscheduler/pull/10886/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa8b88a...cbef534](https://codecov.io/gh/apache/dolphinscheduler/pull/10886?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181315410
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181260040
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181317895
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#discussion_r918556199
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskExecuteRunningProcessor.java:
##########
@@ -54,10 +54,10 @@ public class TaskExecuteRunningProcessor implements NettyRequestProcessor {
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_EXECUTE_RUNNING == command.getType(), String.format("invalid command type : %s", command.getType()));
- TaskExecuteRunningCommand taskExecuteRunningCommand = JSONUtils.parseObject(command.getBody(), TaskExecuteRunningCommand.class);
- logger.info("taskExecuteRunningCommand: {}", taskExecuteRunningCommand);
+ TaskExecuteRunningCommand taskExecuteRunningMessage = JSONUtils.parseObject(command.getBody(), TaskExecuteRunningCommand.class);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180561856
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [30 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181338675
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun merged pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181259024
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#discussion_r918556305
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java:
##########
@@ -76,201 +59,201 @@ public TaskCallbackService() {
final NettyClientConfig clientConfig = new NettyClientConfig();
this.nettyRemotingClient = new NettyRemotingClient(clientConfig);
this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RUNNING_ACK, taskExecuteRunningProcessor);
- this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RESPONSE_ACK, taskExecuteResponseAckProcessor);
- }
-
- /**
- * add callback channel
- *
- * @param taskInstanceId taskInstanceId
- * @param channel channel
- */
- public void addRemoteChannel(int taskInstanceId, NettyRemoteChannel channel) {
- REMOTE_CHANNELS.put(taskInstanceId, channel);
- }
-
- /**
- * change remote channel
- */
- public void changeRemoteChannel(int taskInstanceId, NettyRemoteChannel channel) {
- REMOTE_CHANNELS.put(taskInstanceId, channel);
- }
-
- /**
- * get callback channel
- *
- * @param taskInstanceId taskInstanceId
- * @return callback channel
- */
- private Optional<NettyRemoteChannel> getRemoteChannel(int taskInstanceId) {
- Channel newChannel;
- NettyRemoteChannel nettyRemoteChannel = REMOTE_CHANNELS.get(taskInstanceId);
- if (nettyRemoteChannel != null) {
- if (nettyRemoteChannel.isActive()) {
- return Optional.of(nettyRemoteChannel);
- }
- newChannel = nettyRemotingClient.getChannel(nettyRemoteChannel.getHost());
- if (newChannel != null) {
- return Optional.of(getRemoteChannel(newChannel, nettyRemoteChannel.getOpaque(), taskInstanceId));
- }
- }
- return Optional.empty();
- }
-
- public long pause(int ntries) {
- return SLEEP_TIME_MILLIS * RETRY_BACKOFF[ntries % RETRY_BACKOFF.length];
- }
-
- private NettyRemoteChannel getRemoteChannel(Channel newChannel, long opaque, int taskInstanceId) {
- NettyRemoteChannel remoteChannel = new NettyRemoteChannel(newChannel, opaque);
- addRemoteChannel(taskInstanceId, remoteChannel);
- return remoteChannel;
- }
-
- private NettyRemoteChannel getRemoteChannel(Channel newChannel, int taskInstanceId) {
- NettyRemoteChannel remoteChannel = new NettyRemoteChannel(newChannel);
- addRemoteChannel(taskInstanceId, remoteChannel);
- return remoteChannel;
+ this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RESULT_ACK, taskExecuteResultAckProcessor);
}
- /**
- * remove callback channels
- *
- * @param taskInstanceId taskInstanceId
- */
- public static void remove(int taskInstanceId) {
- REMOTE_CHANNELS.remove(taskInstanceId);
- }
-
- /**
- * send result
- *
- * @param taskInstanceId taskInstanceId
- * @param command command
- */
- public void send(int taskInstanceId, Command command) {
- Optional<NettyRemoteChannel> nettyRemoteChannel = getRemoteChannel(taskInstanceId);
- if (nettyRemoteChannel.isPresent()) {
- nettyRemoteChannel.get().writeAndFlush(command).addListener(new ChannelFutureListener() {
- @Override
- public void operationComplete(ChannelFuture future) {
- if (!future.isSuccess()) {
- logger.error("Send callback command error, taskInstanceId: {}, command: {}", taskInstanceId, command);
- }
- }
- });
- } else {
- logger.warn("Remote channel of taskInstanceId is null: {}, cannot send command: {}", taskInstanceId, command);
- }
- }
-
- /**
- * build task execute running command
- *
- * @param taskExecutionContext taskExecutionContext
- * @return TaskExecuteAckCommand
- */
- private TaskExecuteRunningCommand buildTaskExecuteRunningCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = new TaskExecuteRunningCommand();
- command.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- command.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- command.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- command.setLogPath(taskExecutionContext.getLogPath());
- command.setHost(taskExecutionContext.getHost());
- command.setStartTime(taskExecutionContext.getStartTime());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- return command;
- }
-
- /**
- * build task execute response command
- *
- * @param taskExecutionContext taskExecutionContext
- * @return TaskExecuteResponseCommand
- */
- private TaskExecuteResponseCommand buildTaskExecuteResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteResponseCommand command = new TaskExecuteResponseCommand();
- command.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- command.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- command.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- command.setLogPath(taskExecutionContext.getLogPath());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- command.setAppIds(taskExecutionContext.getAppIds());
- command.setProcessId(taskExecutionContext.getProcessId());
- command.setHost(taskExecutionContext.getHost());
- command.setStartTime(taskExecutionContext.getStartTime());
- command.setEndTime(taskExecutionContext.getEndTime());
- command.setVarPool(taskExecutionContext.getVarPool());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- return command;
- }
-
- /**
- * build TaskKillResponseCommand
- *
- * @param taskExecutionContext taskExecutionContext
- * @return build TaskKillResponseCommand
- */
- private TaskKillResponseCommand buildKillTaskResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskKillResponseCommand taskKillResponseCommand = new TaskKillResponseCommand();
- taskKillResponseCommand.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- taskKillResponseCommand.setAppIds(Arrays.asList(taskExecutionContext.getAppIds().split(TaskConstants.COMMA)));
- taskKillResponseCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- taskKillResponseCommand.setHost(taskExecutionContext.getHost());
- taskKillResponseCommand.setProcessId(taskExecutionContext.getProcessId());
- return taskKillResponseCommand;
- }
-
- private TaskRecallCommand buildRecallCommand(TaskExecutionContext taskExecutionContext) {
- TaskRecallCommand taskRecallCommand = new TaskRecallCommand();
- taskRecallCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- taskRecallCommand.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- taskRecallCommand.setHost(taskExecutionContext.getHost());
- return taskRecallCommand;
- }
-
- /**
- * send task execute running command
- * todo unified callback command
- */
- public void sendTaskExecuteRunningCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = buildTaskExecuteRunningCommand(taskExecutionContext);
- // add response cache
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), command.convert2Command(), TaskEventType.RUNNING);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- /**
- * send task execute delay command
- * todo unified callback command
- */
- public void sendTaskExecuteDelayCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = buildTaskExecuteRunningCommand(taskExecutionContext);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- /**
- * send task execute response command
- * todo unified callback command
- */
- public void sendTaskExecuteResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteResponseCommand command = buildTaskExecuteResponseCommand(taskExecutionContext);
- // add response cache
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), command.convert2Command(), TaskEventType.RESULT);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- public void sendTaskKillResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskKillResponseCommand taskKillResponseCommand = buildKillTaskResponseCommand(taskExecutionContext);
- send(taskExecutionContext.getTaskInstanceId(), taskKillResponseCommand.convert2Command());
- }
-
- /**
- * send task execute response command
- */
- public void sendRecallCommand(TaskExecutionContext taskExecutionContext) {
- TaskRecallCommand taskRecallCommand = buildRecallCommand(taskExecutionContext);
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), taskRecallCommand.convert2Command(), TaskEventType.WORKER_REJECT);
- send(taskExecutionContext.getTaskInstanceId(), taskRecallCommand.convert2Command());
- }
+ // /**
Review Comment:
Done
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/rpc/WorkerMessageSender.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.server.worker.rpc;
+
+import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
+import org.apache.dolphinscheduler.remote.command.BaseCommand;
+import org.apache.dolphinscheduler.remote.command.CommandType;
+import org.apache.dolphinscheduler.remote.exceptions.RemotingException;
+import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
+import org.apache.dolphinscheduler.server.worker.message.MessageSender;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.annotation.PostConstruct;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.ApplicationContext;
+import org.springframework.stereotype.Component;
+
+import lombok.NonNull;
+
+@Component
+public class WorkerMessageSender {
+
+ private final Logger logger = LoggerFactory.getLogger(WorkerMessageSender.class);
+
+ @Autowired
+ private MessageRetryRunner messageRetryRunner;
+
+ @Autowired
+ private ApplicationContext applicationContext;
+
+ private Map<CommandType, MessageSender> messageSenderMap = new HashMap<>();
+
+ @PostConstruct
+ public void init() {
+ Map<String, MessageSender> messageSenders = applicationContext.getBeansOfType(MessageSender.class);
+ messageSenders.values().forEach(messageSender -> messageSenderMap.put(messageSender.getMessageType(),
+ messageSender));
+ }
+
+ // todo: use message rather than context
+ public void sendMessageNeedAck(@NonNull TaskExecutionContext taskExecutionContext,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180636128
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181207724
Hi @ruanwenjun I found many changes in this pr is about `command to message`, is it necessary to change it?
I think we can keep the command name to reduce modification and cherry-pick costs, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181221239
> Hi @ruanwenjun I found many changes in this pr is about `command to message`, is it necessary to change it?
> I think we can keep the command name to reduce modification and cherry-pick costs, WDYT?
I add a new class `BaseMessage`, and our async command will extend this class, to get some fields.
I suggestion to rename command to message, since we already have a Command, and the other class is only command body.
Anyway, I will rollback the rename change, but I suggest we can do this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181239464
I will revert the name change related to command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#discussion_r918524582
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskExecuteRunningProcessor.java:
##########
@@ -54,10 +54,10 @@ public class TaskExecuteRunningProcessor implements NettyRequestProcessor {
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_EXECUTE_RUNNING == command.getType(), String.format("invalid command type : %s", command.getType()));
- TaskExecuteRunningCommand taskExecuteRunningCommand = JSONUtils.parseObject(command.getBody(), TaskExecuteRunningCommand.class);
- logger.info("taskExecuteRunningCommand: {}", taskExecuteRunningCommand);
+ TaskExecuteRunningCommand taskExecuteRunningMessage = JSONUtils.parseObject(command.getBody(), TaskExecuteRunningCommand.class);
Review Comment:
nip: revert variable name
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/processor/TaskAckProcessorTest.java:
##########
@@ -44,7 +44,7 @@ public class TaskAckProcessorTest {
private TaskExecuteRunningProcessor taskExecuteRunningProcessor;
private TaskEventService taskEventService;
private ProcessService processService;
- private TaskExecuteRunningCommand taskExecuteRunningCommand;
+ private TaskExecuteRunningCommand taskExecuteRunningMessage;
Review Comment:
same here
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java:
##########
@@ -76,201 +59,201 @@ public TaskCallbackService() {
final NettyClientConfig clientConfig = new NettyClientConfig();
this.nettyRemotingClient = new NettyRemotingClient(clientConfig);
this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RUNNING_ACK, taskExecuteRunningProcessor);
- this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RESPONSE_ACK, taskExecuteResponseAckProcessor);
- }
-
- /**
- * add callback channel
- *
- * @param taskInstanceId taskInstanceId
- * @param channel channel
- */
- public void addRemoteChannel(int taskInstanceId, NettyRemoteChannel channel) {
- REMOTE_CHANNELS.put(taskInstanceId, channel);
- }
-
- /**
- * change remote channel
- */
- public void changeRemoteChannel(int taskInstanceId, NettyRemoteChannel channel) {
- REMOTE_CHANNELS.put(taskInstanceId, channel);
- }
-
- /**
- * get callback channel
- *
- * @param taskInstanceId taskInstanceId
- * @return callback channel
- */
- private Optional<NettyRemoteChannel> getRemoteChannel(int taskInstanceId) {
- Channel newChannel;
- NettyRemoteChannel nettyRemoteChannel = REMOTE_CHANNELS.get(taskInstanceId);
- if (nettyRemoteChannel != null) {
- if (nettyRemoteChannel.isActive()) {
- return Optional.of(nettyRemoteChannel);
- }
- newChannel = nettyRemotingClient.getChannel(nettyRemoteChannel.getHost());
- if (newChannel != null) {
- return Optional.of(getRemoteChannel(newChannel, nettyRemoteChannel.getOpaque(), taskInstanceId));
- }
- }
- return Optional.empty();
- }
-
- public long pause(int ntries) {
- return SLEEP_TIME_MILLIS * RETRY_BACKOFF[ntries % RETRY_BACKOFF.length];
- }
-
- private NettyRemoteChannel getRemoteChannel(Channel newChannel, long opaque, int taskInstanceId) {
- NettyRemoteChannel remoteChannel = new NettyRemoteChannel(newChannel, opaque);
- addRemoteChannel(taskInstanceId, remoteChannel);
- return remoteChannel;
- }
-
- private NettyRemoteChannel getRemoteChannel(Channel newChannel, int taskInstanceId) {
- NettyRemoteChannel remoteChannel = new NettyRemoteChannel(newChannel);
- addRemoteChannel(taskInstanceId, remoteChannel);
- return remoteChannel;
+ this.nettyRemotingClient.registerProcessor(CommandType.TASK_EXECUTE_RESULT_ACK, taskExecuteResultAckProcessor);
}
- /**
- * remove callback channels
- *
- * @param taskInstanceId taskInstanceId
- */
- public static void remove(int taskInstanceId) {
- REMOTE_CHANNELS.remove(taskInstanceId);
- }
-
- /**
- * send result
- *
- * @param taskInstanceId taskInstanceId
- * @param command command
- */
- public void send(int taskInstanceId, Command command) {
- Optional<NettyRemoteChannel> nettyRemoteChannel = getRemoteChannel(taskInstanceId);
- if (nettyRemoteChannel.isPresent()) {
- nettyRemoteChannel.get().writeAndFlush(command).addListener(new ChannelFutureListener() {
- @Override
- public void operationComplete(ChannelFuture future) {
- if (!future.isSuccess()) {
- logger.error("Send callback command error, taskInstanceId: {}, command: {}", taskInstanceId, command);
- }
- }
- });
- } else {
- logger.warn("Remote channel of taskInstanceId is null: {}, cannot send command: {}", taskInstanceId, command);
- }
- }
-
- /**
- * build task execute running command
- *
- * @param taskExecutionContext taskExecutionContext
- * @return TaskExecuteAckCommand
- */
- private TaskExecuteRunningCommand buildTaskExecuteRunningCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = new TaskExecuteRunningCommand();
- command.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- command.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- command.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- command.setLogPath(taskExecutionContext.getLogPath());
- command.setHost(taskExecutionContext.getHost());
- command.setStartTime(taskExecutionContext.getStartTime());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- return command;
- }
-
- /**
- * build task execute response command
- *
- * @param taskExecutionContext taskExecutionContext
- * @return TaskExecuteResponseCommand
- */
- private TaskExecuteResponseCommand buildTaskExecuteResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteResponseCommand command = new TaskExecuteResponseCommand();
- command.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- command.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- command.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- command.setLogPath(taskExecutionContext.getLogPath());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- command.setAppIds(taskExecutionContext.getAppIds());
- command.setProcessId(taskExecutionContext.getProcessId());
- command.setHost(taskExecutionContext.getHost());
- command.setStartTime(taskExecutionContext.getStartTime());
- command.setEndTime(taskExecutionContext.getEndTime());
- command.setVarPool(taskExecutionContext.getVarPool());
- command.setExecutePath(taskExecutionContext.getExecutePath());
- return command;
- }
-
- /**
- * build TaskKillResponseCommand
- *
- * @param taskExecutionContext taskExecutionContext
- * @return build TaskKillResponseCommand
- */
- private TaskKillResponseCommand buildKillTaskResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskKillResponseCommand taskKillResponseCommand = new TaskKillResponseCommand();
- taskKillResponseCommand.setStatus(taskExecutionContext.getCurrentExecutionStatus().getCode());
- taskKillResponseCommand.setAppIds(Arrays.asList(taskExecutionContext.getAppIds().split(TaskConstants.COMMA)));
- taskKillResponseCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- taskKillResponseCommand.setHost(taskExecutionContext.getHost());
- taskKillResponseCommand.setProcessId(taskExecutionContext.getProcessId());
- return taskKillResponseCommand;
- }
-
- private TaskRecallCommand buildRecallCommand(TaskExecutionContext taskExecutionContext) {
- TaskRecallCommand taskRecallCommand = new TaskRecallCommand();
- taskRecallCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
- taskRecallCommand.setProcessInstanceId(taskExecutionContext.getProcessInstanceId());
- taskRecallCommand.setHost(taskExecutionContext.getHost());
- return taskRecallCommand;
- }
-
- /**
- * send task execute running command
- * todo unified callback command
- */
- public void sendTaskExecuteRunningCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = buildTaskExecuteRunningCommand(taskExecutionContext);
- // add response cache
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), command.convert2Command(), TaskEventType.RUNNING);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- /**
- * send task execute delay command
- * todo unified callback command
- */
- public void sendTaskExecuteDelayCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteRunningCommand command = buildTaskExecuteRunningCommand(taskExecutionContext);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- /**
- * send task execute response command
- * todo unified callback command
- */
- public void sendTaskExecuteResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskExecuteResponseCommand command = buildTaskExecuteResponseCommand(taskExecutionContext);
- // add response cache
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), command.convert2Command(), TaskEventType.RESULT);
- send(taskExecutionContext.getTaskInstanceId(), command.convert2Command());
- }
-
- public void sendTaskKillResponseCommand(TaskExecutionContext taskExecutionContext) {
- TaskKillResponseCommand taskKillResponseCommand = buildKillTaskResponseCommand(taskExecutionContext);
- send(taskExecutionContext.getTaskInstanceId(), taskKillResponseCommand.convert2Command());
- }
-
- /**
- * send task execute response command
- */
- public void sendRecallCommand(TaskExecutionContext taskExecutionContext) {
- TaskRecallCommand taskRecallCommand = buildRecallCommand(taskExecutionContext);
- ResponseCache.get().cache(taskExecutionContext.getTaskInstanceId(), taskRecallCommand.convert2Command(), TaskEventType.WORKER_REJECT);
- send(taskExecutionContext.getTaskInstanceId(), taskRecallCommand.convert2Command());
- }
+ // /**
Review Comment:
maybe it should be removed.
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/message/MessageSender.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.server.worker.message;
+
+import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
+import org.apache.dolphinscheduler.remote.command.BaseCommand;
+import org.apache.dolphinscheduler.remote.command.CommandType;
+import org.apache.dolphinscheduler.remote.exceptions.RemotingException;
+
+public interface MessageSender<T extends BaseCommand> {
Review Comment:
:+1:
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/rpc/WorkerMessageSender.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.server.worker.rpc;
+
+import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
+import org.apache.dolphinscheduler.remote.command.BaseCommand;
+import org.apache.dolphinscheduler.remote.command.CommandType;
+import org.apache.dolphinscheduler.remote.exceptions.RemotingException;
+import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
+import org.apache.dolphinscheduler.server.worker.message.MessageSender;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.annotation.PostConstruct;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.ApplicationContext;
+import org.springframework.stereotype.Component;
+
+import lombok.NonNull;
+
+@Component
+public class WorkerMessageSender {
+
+ private final Logger logger = LoggerFactory.getLogger(WorkerMessageSender.class);
+
+ @Autowired
+ private MessageRetryRunner messageRetryRunner;
+
+ @Autowired
+ private ApplicationContext applicationContext;
+
+ private Map<CommandType, MessageSender> messageSenderMap = new HashMap<>();
+
+ @PostConstruct
+ public void init() {
+ Map<String, MessageSender> messageSenders = applicationContext.getBeansOfType(MessageSender.class);
+ messageSenders.values().forEach(messageSender -> messageSenderMap.put(messageSender.getMessageType(),
+ messageSender));
+ }
+
+ // todo: use message rather than context
+ public void sendMessageNeedAck(@NonNull TaskExecutionContext taskExecutionContext,
Review Comment:
```suggestion
public void sendMessageWithRetry(@NonNull TaskExecutionContext taskExecutionContext,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181337325
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180554039
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [30 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180631013
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10886)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL) [31 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10886&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list) [2.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10886&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10886: [Fix-10827] Fix network error cause worker cannot send message to master
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10886:
URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1180606366
@caishunfeng This PR is ready to review, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org