You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/08/02 15:37:47 UTC
Re: Review Request 13132: Field default value functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13132/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 1:37 p.m.)
Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
Repository: cloudstack-git
Description
-------
Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time.
Diffs
-----
ui/scripts/sharedFunctions.js 8ddaeaf
ui/scripts/ui/dialog.js 1ff5401
Diff: https://reviews.apache.org/r/13132/diff/
Testing
-------
Thanks,
Chris Suich
Re: Review Request 13132: Field default value functions
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13132/#review25152
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13132/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 1:37 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time.
>
>
> Diffs
> -----
>
> ui/scripts/sharedFunctions.js 8ddaeaf
> ui/scripts/ui/dialog.js 1ff5401
>
> Diff: https://reviews.apache.org/r/13132/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>
>
Re: Review Request 13132: Field default value functions
Posted by "SuichII, Christopher" <Ch...@netapp.com>.
Is this something I've broken?
On Aug 14, 2013, at 1:36 PM, Jenkins Cloudstack.org<http://Cloudstack.org> <hu...@apache.org>>
wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/
Review 13132 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #135 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/135/
- Jenkins Cloudstack.org<http://Cloudstack.org>
On August 2nd, 2013, 1:37 p.m. UTC, Chris Suich wrote:
Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
By Chris Suich.
Updated Aug. 2, 2013, 1:37 p.m.
Repository: cloudstack-git
Description
Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time.
Diffs
* ui/scripts/sharedFunctions.js (8ddaeaf)
* ui/scripts/ui/dialog.js (1ff5401)
View Diff<https://reviews.apache.org/r/13132/diff/>
Re: Review Request 13132: Field default value functions
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13132/#review25154
-----------------------------------------------------------
Review 13132 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #135 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/135/
- Jenkins Cloudstack.org
On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13132/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 1:37 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time.
>
>
> Diffs
> -----
>
> ui/scripts/sharedFunctions.js 8ddaeaf
> ui/scripts/ui/dialog.js 1ff5401
>
> Diff: https://reviews.apache.org/r/13132/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>
>