You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/23 17:34:49 UTC
[GitHub] [airflow] pingzh opened a new pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
pingzh opened a new pull request #22491:
URL: https://github.com/apache/airflow/pull/22491
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
solves this issue https://github.com/apache/airflow/issues/8989
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #22491:
URL: https://github.com/apache/airflow/pull/22491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh closed pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
pingzh closed pull request #22491:
URL: https://github.com/apache/airflow/pull/22491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on a change in pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
pingzh commented on a change in pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#discussion_r834500764
##########
File path: airflow/ti_deps/deps/prev_dagrun_dep.py
##########
@@ -66,6 +67,23 @@ def _get_dep_statuses(self, ti, session, dep_context):
previous_ti = last_dagrun.get_task_instance(ti.task_id, session=session)
if not previous_ti:
+ if ti.task.ignore_first_depends_on_past:
+ historical_ti = (
+ session.query(TI)
+ .filter(
+ TI.dag_id == ti.dag_id,
+ TI.task_id == ti.task_id,
+ TI.execution_date < ti.execution_date,
+ )
+ .first()
+ )
Review comment:
good idea. I have tried to use `exist` but some db does not support that. let me update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
pingzh commented on pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#issuecomment-1077828855
@uranusjr addressed your feedback. hmm, very strange, the CI is not triggered to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#discussion_r834174737
##########
File path: airflow/ti_deps/deps/prev_dagrun_dep.py
##########
@@ -66,6 +67,23 @@ def _get_dep_statuses(self, ti, session, dep_context):
previous_ti = last_dagrun.get_task_instance(ti.task_id, session=session)
if not previous_ti:
+ if ti.task.ignore_first_depends_on_past:
+ historical_ti = (
+ session.query(TI)
+ .filter(
+ TI.dag_id == ti.dag_id,
+ TI.task_id == ti.task_id,
+ TI.execution_date < ti.execution_date,
+ )
+ .first()
+ )
Review comment:
Alternatively we could do `session.query(func.count()).filter(...).scalar() > 0`, which is probably slower, but still reasonable since the filtered columns are indexed, and arguably most readable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh edited a comment on pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
pingzh edited a comment on pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#issuecomment-1077828855
@uranusjr addressed your feedback. hmm, very strange, the CI is not triggered to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#issuecomment-1076879322
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22491: Add ignore_first_depends_on_past for scheduled jobs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22491:
URL: https://github.com/apache/airflow/pull/22491#discussion_r834173046
##########
File path: airflow/ti_deps/deps/prev_dagrun_dep.py
##########
@@ -66,6 +67,23 @@ def _get_dep_statuses(self, ti, session, dep_context):
previous_ti = last_dagrun.get_task_instance(ti.task_id, session=session)
if not previous_ti:
+ if ti.task.ignore_first_depends_on_past:
+ historical_ti = (
+ session.query(TI)
+ .filter(
+ TI.dag_id == ti.dag_id,
+ TI.task_id == ti.task_id,
+ TI.execution_date < ti.execution_date,
+ )
+ .first()
+ )
Review comment:
```suggestion
historical_ti = (
session.query(literal(True))
.filter(
TI.dag_id == ti.dag_id,
TI.task_id == ti.task_id,
TI.execution_date < ti.execution_date,
)
.first()
)
```
This would save some deserialisation effort since we don’t actually care about the selected task instance, but only whether it exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org