You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/25 08:53:54 UTC

[GitHub] [pulsar] Shoothzj opened a new pull request #9061: Make netty acceptor thread can config

Shoothzj opened a new pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061


   ### Motivation
   
   When the consumer application which serves ten thousands of consumers start, the default netty acceptor config opens slow. Make the consumer bootstrap costs long time.
   ### Modifications
   
   Make Netty acceptor threads can config, so people can tuning.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? yes 
     - If yes, how is the feature documented? docs / JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #9061: Make Netty Acceptor ThreadPool size configurable

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061#issuecomment-751304573


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9061: Make netty acceptor thread can config

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061#issuecomment-751213708


   @Shoothzj It's better to use a new branch to push PR, For more details, you can see http://pulsar.apache.org/en/contributing/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9061: Make Netty Acceptor ThreadPool size configurable

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #9061: Make Netty Acceptor ThreadPool size configurable

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061#issuecomment-751305167


   > LGTM
   > 
   > Please edit the title: "Make Netty Acceptor ThreadPool size configurable"
   
   Alreay Edited


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #9061: Make Netty Acceptor ThreadPool size configurable

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #9061:
URL: https://github.com/apache/pulsar/pull/9061#issuecomment-751305193


   > @Shoothzj It's better to use a new branch to push PR, For more details, you can see http://pulsar.apache.org/en/contributing/
   
   Ok, next time I will use a new branch to push PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org