You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/29 20:13:44 UTC

[GitHub] [arrow] bkmgit opened a new pull request #11275: ARROW-14178: [C++] Boost download location has moved

bkmgit opened a new pull request #11275:
URL: https://github.com/apache/arrow/pull/11275


   https://www.boost.org/users/news/boost_has_moved_downloads_to_jfr.html
   
   Tagged releases on GitHub do not include submodules


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-930508912


   https://issues.apache.org/jira/browse/ARROW-14178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkmgit commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
bkmgit commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-933319324


   Related to https://issues.apache.org/jira/projects/ARROW/issues/ARROW-6407
   - Maybe alternate URLs also needed in https://github.com/apache/arrow/blob/master/cpp/thirdparty/versions.txt ?
   - Trimmed Boost could also be uploaded to a different location? 
   - [FetchContent](https://cmake.org/cmake/help/latest/module/FetchContent.html) will need CMake 3.11 or 3.14 as minimum rather than 3.5.
   -  [FileDownload](https://cmake.org/cmake/help/latest/command/file.html#transfer) can be used with if statements, for example as done in [CMake tests](https://gitlab.kitware.com/cmake/cmake/-/blob/master/Tests/CMakeTests/FileDownloadTest.cmake.in) and also described on [StackOverflow 6125573](https://stackoverflow.com/questions/61255773/cmake-file-download-ignores-errors), though this might require higher maintenance burden


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-935650547


   It seems that ARROW-6407 isn't a good place to discuss this. It's more generic. We just want to remove checksum only for Boost as a workaround for now.
   
   The real fix may use ARROW-6407. (We may use `file(DOWNLOAD)` https://cmake.org/cmake/help/latest/command/file.html#download for checking trimmed Boost availability and choose suitable download URLs and checksum. We will use trimmed Boost's URL and checksum when it's available. Otherwise, normal boost download URLs and checksum.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-930508912


   https://issues.apache.org/jira/browse/ARROW-14178


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkmgit commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
bkmgit commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-934095673


   @kou Happy to work on it. Maybe discussion can be done in https://issues.apache.org/jira/projects/ARROW/issues/ARROW-6407 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou closed pull request #11275:
URL: https://github.com/apache/arrow/pull/11275


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkmgit commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
bkmgit commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-939978578


   This requires a recent version of CMake, 3.11 (released 2018 December 1) or 3.14 (released 2019 March 14), so `dile(DOWNLOAD)` seems better.  [ParaView superbuild](https://gitlab.kitware.com/paraview/paraview-superbuild/-/tree/master/) has an option to download all dependencies first, and then build, so maybe can update the download script to try different locations successively.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#discussion_r718886218



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -402,7 +402,7 @@ else()
            # ${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}
            "https://github.com/ursa-labs/thirdparty/releases/download/latest/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"
            "https://sourceforge.net/projects/boost/files/boost/${ARROW_BOOST_BUILD_VERSION}/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"
-           "https://github.com/boostorg/boost/archive/boost-${ARROW_BOOST_BUILD_VERSION}.tar.gz"
+           "https://boostorg.jfrog.io/artifactory/main/release/${ARROW_BOOST_BUILD_VERSION}/source/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"

Review comment:
       How about prioritizing boostorg.jfrog.org over sourceforge.net?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#discussion_r718886218



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -402,7 +402,7 @@ else()
            # ${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}
            "https://github.com/ursa-labs/thirdparty/releases/download/latest/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"
            "https://sourceforge.net/projects/boost/files/boost/${ARROW_BOOST_BUILD_VERSION}/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"
-           "https://github.com/boostorg/boost/archive/boost-${ARROW_BOOST_BUILD_VERSION}.tar.gz"
+           "https://boostorg.jfrog.io/artifactory/main/release/${ARROW_BOOST_BUILD_VERSION}/source/boost_${ARROW_BOOST_BUILD_VERSION_UNDERSCORES}.tar.gz"

Review comment:
       How about prioritizing boostorg.jfrog.org over sourceforge.net?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-939808302


   (Or we may use `FileContent` https://cmake.org/cmake/help/latest/module/FetchContent.html .)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-933957112


   > The quickest fix might be to remove the checksum for boost.
   
   This sounds reasonable. @bkmgit Do you want to work on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #11275: ARROW-14178: [C++] Boost download location has moved

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #11275:
URL: https://github.com/apache/arrow/pull/11275#issuecomment-933764906


   I think boost is the only one we trim, all of the other backup URLs should have the same hashes. The quickest fix might be to remove the checksum for boost. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org