You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/07 12:14:04 UTC

[GitHub] [hadoop] pustota2009 opened a new pull request #1884: [HDFS-15202] Boost short circuit cache

pustota2009 opened a new pull request #1884: [HDFS-15202] Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884
 
 
   Improve HDFS-client reading performance. 
   The idea: create few instances ShortCircuit caches instead of one.
   It helps avoid locks and let CPU do jobs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596185243
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  7s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m  6s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 34s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  6s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 38s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m 16s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 55s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 32s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 39s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvninstall  |   1m  1s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 41s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   0m 41s |  hadoop-hdfs-project in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   0m 56s |  the patch passed  |
   | -1 :x: |  mvnsite  |   0m 44s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvnsite  |   1m 18s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   3m 26s |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 25s |  the patch passed  |
   | -1 :x: |  findbugs  |   1m  5s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  findbugs  |   1m 34s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 57s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  unit  |   1m 40s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  The patch does not generate ASF License warnings.  |
   |  |   |  72m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux d067deff3c8e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/whitespace-eol.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/testReport/ |
   | Max. process+thread count | 315 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/3/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] jojochuang commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#discussion_r399083749
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
 ##########
 @@ -4137,6 +4137,14 @@
   </description>
 </property>
 
+<property>
+  <name>dfs.short.circuit.num</name>
+  <value>1</value>
+  <description>
+    Number of short-circuit caches.
 
 Review comment:
   Please update with the allowed range here. ( 1 <= num <= 5)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] pustota2009 commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
pustota2009 commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#discussion_r399620246
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
 ##########
 @@ -290,6 +291,16 @@ public DfsClientConf(Configuration conf) {
     leaseHardLimitPeriod =
         conf.getLong(HdfsClientConfigKeys.DFS_LEASE_HARDLIMIT_KEY,
             HdfsClientConfigKeys.DFS_LEASE_HARDLIMIT_DEFAULT) * 1000;
+
+    clientShortCircuitNum = conf.getInt(
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM_DEFAULT);
+    Preconditions.checkArgument(clientShortCircuitNum >= 1,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM +
+        "can't be less then 1.");
+    Preconditions.checkArgument(clientShortCircuitNum <= 5,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM +
 
 Review comment:
   I'm not sure but afraid if someone has slowly CPU and set some big value (10 for example) it may overload CPU and negative affect to other processes. The second reason, after 5 increasing performance quite small.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596618973
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m  9s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 29s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 13s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 59s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 17s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 16s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 26s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 57s |  hadoop-hdfs-project: The patch generated 1 new + 347 unchanged - 0 fixed = 348 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 54s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 11s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  7s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 29s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 59s |  hadoop-hdfs-client in the patch passed.  |
   | +1 :green_heart: |  unit  |  99m  1s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 38s |  The patch does not generate ASF License warnings.  |
   |  |   | 185m 22s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/14/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 238e85baed40 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 6dfe00c |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/14/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/14/testReport/ |
   | Max. process+thread count | 3485 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/14/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596494701
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 26s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 22s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 19s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 59s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 17s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 15s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 53s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 54s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 10s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 28s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 59s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |  90m 55s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate ASF License warnings.  |
   |  |   | 177m 40s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/13/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 1ed42edb3fbf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 6dfe00c |
   | Default Java | 1.8.0_242 |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/13/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/13/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/13/testReport/ |
   | Max. process+thread count | 3413 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/13/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-605413079
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 16s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  2s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 41s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 40s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  2s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  5s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 34s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  2s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 20s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 18s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 29s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 29s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 56s |  hadoop-hdfs-project: The patch generated 1 new + 347 unchanged - 0 fixed = 348 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 53s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 23s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 32s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 59s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 108m 59s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 54s |  The patch does not generate ASF License warnings.  |
   |  |   | 198m 50s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.balancer.TestBalancer |
   |   | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/16/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 6c0dc15abe70 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / f531a4a |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/16/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/16/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/16/testReport/ |
   | Max. process+thread count | 3194 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/16/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] pustota2009 removed a comment on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
pustota2009 removed a comment on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596956556
 
 
   @aajisaka 
   Could you take a look, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-609544451
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 45s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  22m  3s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  0s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 26s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  0s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 17s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 15s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 25s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 25s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 58s |  hadoop-hdfs-project: The patch generated 9 new + 342 unchanged - 5 fixed = 351 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 20s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 59s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |  88m 51s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate ASF License warnings.  |
   |  |   | 177m  8s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized |
   |   | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/19/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 3ca43cfead7d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / e6455cc |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/19/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/19/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/19/testReport/ |
   | Max. process+thread count | 3630 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/19/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596254321
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 16s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 25s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 15s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 13s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 53s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 23s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 23s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 56s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 52s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 10 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  shadedclient  |  15m 16s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 29s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 57s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |  89m 56s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate ASF License warnings.  |
   |  |   | 176m 33s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage |
   |   | hadoop.tools.TestHdfsConfigFields |
   |   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/9/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux cbbd6b5bf945 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/9/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/9/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/9/testReport/ |
   | Max. process+thread count | 3264 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/9/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] jojochuang commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#discussion_r399084460
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/DfsClientConf.java
 ##########
 @@ -290,6 +291,16 @@ public DfsClientConf(Configuration conf) {
     leaseHardLimitPeriod =
         conf.getLong(HdfsClientConfigKeys.DFS_LEASE_HARDLIMIT_KEY,
             HdfsClientConfigKeys.DFS_LEASE_HARDLIMIT_DEFAULT) * 1000;
+
+    clientShortCircuitNum = conf.getInt(
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM_DEFAULT);
+    Preconditions.checkArgument(clientShortCircuitNum >= 1,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM +
+        "can't be less then 1.");
+    Preconditions.checkArgument(clientShortCircuitNum <= 5,
+        HdfsClientConfigKeys.DFS_SHORT_CIRCUIT_NUM +
 
 Review comment:
   any reason why this is limited to 5?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-603638446
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  23m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 59s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 20s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  0s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 28s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 59s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 19s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 15s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 23s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 23s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 56s |  hadoop-hdfs-project: The patch generated 1 new + 347 unchanged - 0 fixed = 348 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 52s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 13s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 52s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 12s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 106m 56s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 34s |  The patch does not generate ASF License warnings.  |
   |  |   | 219m  4s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.datanode.TestBPOfferService |
   |   | hadoop.hdfs.TestEncryptionZonesWithKMS |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/15/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux c7c0fb7ea416 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / d353b30 |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/15/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/15/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/15/testReport/ |
   | Max. process+thread count | 3247 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/15/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-609502946
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 49s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  23m 13s |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  3s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  5s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m 14s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m 20s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 58s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 36s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 52s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 52s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 59s |  hadoop-hdfs-project: The patch generated 27 new + 346 unchanged - 1 fixed = 373 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   2m  0s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 23s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 12s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   6m 22s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  9s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 124m 22s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 48s |  The patch does not generate ASF License warnings.  |
   |  |   | 219m 43s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestMultipleNNPortQOP |
   |   | hadoop.hdfs.server.datanode.TestBPOfferService |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/18/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux d65b007c5f36 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / e6455cc |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/18/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/18/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/18/testReport/ |
   | Max. process+thread count | 2747 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/18/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596088857
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 29s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  8s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m  3s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   0m 59s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 22s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 16s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 14s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 38s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvninstall  |   0m 58s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 39s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   0m 39s |  hadoop-hdfs-project in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 54s |  hadoop-hdfs-project: The patch generated 6 new + 272 unchanged - 0 fixed = 278 total (was 272)  |
   | -1 :x: |  mvnsite  |   0m 39s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvnsite  |   1m  1s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   3m  2s |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  1s |  the patch passed  |
   | -1 :x: |  findbugs  |   0m 39s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  findbugs  |   0m 59s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 41s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  unit  |   1m  0s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 24s |  The patch does not generate ASF License warnings.  |
   |  |   |  66m 58s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | JIRA Issue | HDFS-15202 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux fa94bfc3aaaf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 3859fa7 |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/whitespace-eol.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/testReport/ |
   | Max. process+thread count | 309 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/1/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596197154
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 29s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | -1 :x: |  mvninstall  |   1m 38s |  root in trunk failed.  |
   | -1 :x: |  compile  |   0m 22s |  hadoop-hdfs-project in trunk failed.  |
   | -0 :warning: |  checkstyle  |   0m 19s |  The patch fails to run checkstyle in hadoop-hdfs-project  |
   | -1 :x: |  mvnsite  |   0m 56s |  hadoop-hdfs-client in trunk failed.  |
   | -1 :x: |  mvnsite  |   0m 23s |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |   1m 50s |  branch has no errors when building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 22s |  hadoop-hdfs-client in trunk failed.  |
   | -1 :x: |  javadoc  |   0m 23s |  hadoop-hdfs in trunk failed.  |
   | +0 :ok: |  spotbugs  |   3m 21s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 23s |  hadoop-hdfs-client in trunk failed.  |
   | -1 :x: |  findbugs  |   0m 22s |  hadoop-hdfs in trunk failed.  |
   | -0 :warning: |  patch  |   3m 40s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 22s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvninstall  |   0m 13s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   1m 37s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   1m 37s |  hadoop-hdfs-project in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 56s |  hadoop-hdfs-project: The patch generated 272 new + 0 unchanged - 0 fixed = 272 total (was 0)  |
   | -1 :x: |  mvnsite  |   1m 22s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   4m 55s |  patch has errors when building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 27s |  hadoop-hdfs-project_hadoop-hdfs-client generated 100 new + 0 unchanged - 0 fixed = 100 total (was 0)  |
   | -1 :x: |  javadoc  |   0m 38s |  hadoop-hdfs-project_hadoop-hdfs generated 100 new + 0 unchanged - 0 fixed = 100 total (was 0)  |
   | -1 :x: |  findbugs  |   1m  0s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 58s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |   1m  0s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 25s |  The patch does not generate ASF License warnings.  |
   |  |   |  28m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux a6ba6d554ce0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-mvninstall-root.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-compile-hadoop-hdfs-project.txt |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1884/out/maven-branch-checkstyle-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/whitespace-eol.txt |
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/testReport/ |
   | Max. process+thread count | 224 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/5/console |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] pustota2009 commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
pustota2009 commented on a change in pull request #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#discussion_r399620625
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
 ##########
 @@ -4137,6 +4137,14 @@
   </description>
 </property>
 
+<property>
+  <name>dfs.short.circuit.num</name>
+  <value>1</value>
+  <description>
+    Number of short-circuit caches.
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596233499
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 29s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 57s |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m 16s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 15s |  trunk passed  |
   | -1 :x: |  mvnsite  |   1m 14s |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  18m 52s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 12s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 37s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   1m  6s |  hadoop-hdfs in trunk failed.  |
   | -0 :warning: |  patch  |   2m 56s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  4s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 53s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 53s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 29s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  shadedclient  |  17m  8s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 14s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   6m 41s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  4s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |  98m  9s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 34s |  The patch does not generate ASF License warnings.  |
   |  |   | 190m 17s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized |
   |   | hadoop.tools.TestHdfsConfigFields |
   |   | hadoop.hdfs.server.namenode.TestReconstructStripedBlocks |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux e43f598945cc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/testReport/ |
   | Max. process+thread count | 3577 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/8/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-609656777
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 10s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 51s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 39s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  4s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 44s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  0s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 19s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 16s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 26s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  hadoop-hdfs-project: The patch generated 0 new + 342 unchanged - 5 fixed = 342 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 36s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  7s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  0s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 109m 35s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  The patch does not generate ASF License warnings.  |
   |  |   | 199m  6s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestMultipleNNPortQOP |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/20/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 1919a61ce180 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / b89d875 |
   | Default Java | 1.8.0_242 |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/20/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/20/testReport/ |
   | Max. process+thread count | 2835 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/20/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596190791
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 12s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 40s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 40s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  1s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 28s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 12s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 16s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 14s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m  1s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   1m 30s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   1m 30s |  hadoop-hdfs-project in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 56s |  hadoop-hdfs-project: The patch generated 1 new + 272 unchanged - 0 fixed = 273 total (was 272)  |
   | -1 :x: |  mvnsite  |   1m  0s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   4m 15s |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  3s |  the patch passed  |
   | -1 :x: |  findbugs  |   2m 28s |  hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | -1 :x: |  findbugs  |   0m 59s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 57s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |   1m  2s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate ASF License warnings.  |
   |  |   |  74m 41s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-hdfs-project/hadoop-hdfs-client |
   |  |  Nullcheck of slot at line 590 of value previously dereferenced in org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.requestFileDescriptors(DomainPeer, ShortCircuitShm$Slot)  At BlockReaderFactory.java:590 of value previously dereferenced in org.apache.hadoop.hdfs.client.impl.BlockReaderFactory.requestFileDescriptors(DomainPeer, ShortCircuitShm$Slot)  At BlockReaderFactory.java:[line 587] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 6ec8e6f78489 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/whitespace-eol.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/testReport/ |
   | Max. process+thread count | 308 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/4/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596231162
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m  1s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  6s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  19m  1s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  1s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 24s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 17s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  4s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 18s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 18s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 59s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m  7s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  shadedclient  |  15m 18s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 13s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   6m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 19s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 105m 29s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  The patch does not generate ASF License warnings.  |
   |  |   | 195m 31s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.balancer.TestBalancer |
   |   | hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage |
   |   | hadoop.hdfs.TestReconstructStripedFile |
   |   | hadoop.tools.TestHdfsConfigFields |
   |   | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/7/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 3edba67a2a2d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/7/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/7/testReport/ |
   | Max. process+thread count | 3294 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/7/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-609037568
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m 52s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 25s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 37s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  8s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 32s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 16s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 13s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 28s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 28s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 58s |  hadoop-hdfs-project: The patch generated 5 new + 347 unchanged - 0 fixed = 352 total (was 347)  |
   | +1 :green_heart: |  mvnsite  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 23s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  5s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 58s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 107m 37s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate ASF License warnings.  |
   |  |   | 197m 53s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.datanode.TestDataNodeLifeline |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/17/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux b4edf8affd87 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / e6455cc |
   | Default Java | 1.8.0_242 |
   | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/17/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/17/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/17/testReport/ |
   | Max. process+thread count | 3190 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/17/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596397078
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 25s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  1s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 13s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 30s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 42s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  0s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 20s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 15s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 12s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |   4m 17s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m  4s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 10 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  15m 19s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   6m 22s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 11s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 100m 53s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  The patch does not generate ASF License warnings.  |
   |  |   | 191m 35s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/11/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 4d3f7b0749c7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 6dfe00c |
   | Default Java | 1.8.0_242 |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/11/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/11/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/11/testReport/ |
   | Max. process+thread count | 3402 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/11/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596365628
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  8s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 52s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 35s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  6s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 38s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   3m  0s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 20s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 16s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 29s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 29s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 54s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 10 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  shadedclient  |  15m 13s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  6s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   5m 30s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 59s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  | 111m 38s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate ASF License warnings.  |
   |  |   | 200m 59s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.tools.TestHdfsConfigFields |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   |   | hadoop.hdfs.TestRollingUpgrade |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/10/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 5f8ca54b766e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/10/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/10/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/10/testReport/ |
   | Max. process+thread count | 2986 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/10/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596409271
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 4 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 31s |  trunk passed  |
   | +1 :green_heart: |  compile  |   4m  5s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m 15s |  trunk passed  |
   | -1 :x: |  mvnsite  |   1m 11s |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |  18m 49s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  9s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 33s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   1m 13s |  hadoop-hdfs in trunk failed.  |
   | -0 :warning: |  patch  |   2m 49s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  9s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 56s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 56s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 57s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 16s |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  2s |  The patch has no ill-formed XML file.  |
   | +1 :green_heart: |  shadedclient  |  17m 33s |  patch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 15s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   6m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 12s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |  97m 43s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 35s |  The patch does not generate ASF License warnings.  |
   |  |   | 189m 27s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy |
   |   | hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor |
   |   | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml |
   | uname | Linux 6e6df1df6435 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 6dfe00c |
   | Default Java | 1.8.0_242 |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/artifact/out/whitespace-eol.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/testReport/ |
   | Max. process+thread count | 3252 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/12/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596182398
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 18s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 47s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 42s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 38s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 14s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 59s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 16s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 15s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 39s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvninstall  |   0m 58s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 39s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   0m 39s |  hadoop-hdfs-project in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   0m 56s |  the patch passed  |
   | -1 :x: |  mvnsite  |   0m 41s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  mvnsite  |   1m  2s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   3m  6s |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  0s |  the patch passed  |
   | -1 :x: |  findbugs  |   0m 40s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  findbugs  |   1m  2s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 40s |  hadoop-hdfs-client in the patch failed.  |
   | -1 :x: |  unit  |   1m  0s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 24s |  The patch does not generate ASF License warnings.  |
   |  |   |  69m 35s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 0ccb0c15309a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/whitespace-eol.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/testReport/ |
   | Max. process+thread count | 296 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/2/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] pustota2009 commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
pustota2009 commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596956556
 
 
   @aajisaka 
   Could you take a look, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache

Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1884: HDFS-15202 Boost short circuit cache
URL: https://github.com/apache/hadoop/pull/1884#issuecomment-596209583
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 15s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 3 new or modified test files.  |
   ||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  21m 36s |  trunk passed  |
   | +1 :green_heart: |  compile  |   3m 33s |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   1m  0s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m  3s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 30s |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 10s |  trunk passed  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 15s |  trunk passed  |
   | -0 :warning: |  patch  |   3m 13s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 59s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   1m 28s |  hadoop-hdfs-project in the patch failed.  |
   | -1 :x: |  javac  |   1m 28s |  hadoop-hdfs-project in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   0m 53s |  the patch passed  |
   | -1 :x: |  mvnsite  |   1m  3s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  shadedclient  |   4m 18s |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m  3s |  the patch passed  |
   | -1 :x: |  findbugs  |   1m  1s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 58s |  hadoop-hdfs-client in the patch passed.  |
   | -1 :x: |  unit  |   1m  1s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate ASF License warnings.  |
   |  |   |  73m 22s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1884 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 19275545ec29 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 999096d |
   | Default Java | 1.8.0_242 |
   | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt |
   | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-compile-hadoop-hdfs-project.txt |
   | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt |
   | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/whitespace-eol.txt |
   | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt |
   | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
   |  Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/testReport/ |
   | Max. process+thread count | 317 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project |
   | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1884/6/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org