[GitHub] [buildstream] gtristan commented on pull request #1609: Directory API refactoring

[GitBox <gi...@apache.org>]

gtristan commented on pull request #1609:
URL: https://github.com/apache/buildstream/pull/1609#issuecomment-1066425803


   [...]
   > I have a couple of comments on these:
   > 
   >     * storage/directory.py: Remove `can_link` parameter from Directory.import_files()
   >       Even though it is currently unused, there is potential to have a similar option that uses  the `move_files` hint  (by passing `--capture-allow-file-moves` to `buildbox-casd`). Can be done later though.
   
   Sure I'll consider this unrelated, in any case it's highly unlikely that we would want to expose the abstract plugin API to such low level implementation details, given that the public API can never again be changed.
   
   >     * storage/directory.py: Make Directory.export_files() an internal function
   >       If we want to go for [source.py: Split up staging functions into separate codepaths. #1607 (comment)](https://github.com/apache/buildstream/pull/1607#issuecomment-1059019265), we'll need to keep this public. Again, this can be made public later if needed (even if it's not at 2.0).
   
   Why ? `Directory.export_files()` is only ever used by the core when *exporting* files in a virtual directory to the local filesystem, when e.g. checking out artifacts or sources, etc. `Directory.import_files()` of course needs to stay public.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org