You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 12:31:55 UTC
[GitHub] [airflow] suhanovv opened a new pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
suhanovv opened a new pull request #17551:
URL: https://github.com/apache/airflow/pull/17551
Fixes for [17512](https://github.com/apache/airflow/issues/17512)
The previous implementation assumed a one-time definition of the offset when creating an instance of the class, which led to the appearance of the same offset in the logs, while the documentation says about uniqueness values.
```
Log messages with specific log_id are sorted based on `offset`,
which is a unique integer indicates log message's order.
```
My implementation adds generation of an offset when creating a log message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17551:
URL: https://github.com/apache/airflow/pull/17551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17551:
URL: https://github.com/apache/airflow/pull/17551#issuecomment-904804777
~ week or so. We are following about monthly cadence of releasing providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17551:
URL: https://github.com/apache/airflow/pull/17551#issuecomment-897204423
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17551:
URL: https://github.com/apache/airflow/pull/17551#issuecomment-896786857
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17551:
URL: https://github.com/apache/airflow/pull/17551#issuecomment-897191897
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] whitleykeith commented on pull request #17551: Fix Invalid log order in ElasticsearchTaskHandler
Posted by GitBox <gi...@apache.org>.
whitleykeith commented on pull request #17551:
URL: https://github.com/apache/airflow/pull/17551#issuecomment-904671778
When will this fix be available? The provider hasn't been updated with these changes yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org