You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/01/16 23:26:52 UTC
[GitHub] couchdb-fauxton pull request: 2546 added sidebar to permissions pa...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/231
2546 added sidebar to permissions page
The code changes are in the first commit. Whitespace/styles fixes in the second.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton 2546-added-sidebar-to-permissions-page
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit b013af3f18472d5d783187d62394e9b1929f4ca4
Author: Benjamin Keen <be...@gmail.com>
Date: 2015-01-16T21:58:38Z
Added sidebar to permissions page
N.B. I stumbled across an old bug while working on this ticket
where the page content wouldn't scroll. That's why there were a
few markup/CSS changes in this ticket as well.
Closes COUCHDB-2546
commit 0fab7752c652c7e0bb69475a236cf79c4e06049b
Author: Benjamin Keen <be...@gmail.com>
Date: 2015-01-16T22:15:39Z
Code cleanup: whitespace, styles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70467188
@benkeen this doesn't quite work. If I click on the permissions page, all the design docs listed in the sidebar disappear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70962295
Thanks @michellephung! I just made a small change; I'll merge once the light goes green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70967881
Merged as aae7b7c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70506479
Ack! Thanks for spotting that @garrensmith, I'll take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70876404
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70521827
All fixed, thanks @garrensmith.
N.B. Now the sidebar consistently shows up, I think I'll create a follow up ticket to retain the hide/show state of the sidebar as you go from page to page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---