You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/12 20:57:49 UTC

[GitHub] mgodave commented on issue #1137: Schema registry

mgodave commented on issue #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059450
 
 
   I tried to do that before and I wasn't happy with how it worked out. I'll
   take another look.
   
   On Mon, Feb 12, 2018 at 1:54 PM, Ivan Kelly <no...@github.com>
   wrote:
   
   > Almost 7000 LoCs. Any chance this could be broken into more digestible
   > pieces for review? Like leave this PR here for reference, for example
   > submit proto files first, and then chunk it into patches around 400-500
   > lines long each that can be reviewed in around an hour?
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365058390>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAh9FgYOeBEcDiWZ0lxy0uG_OPN5-7K_ks5tUKTsgaJpZM4RxagU>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services