[GitHub] cassandra pull request #252: Reduce heap pressure during compactions for CAS...

[krummas <gi...@git.apache.org>]

Github user krummas commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/252#discussion_r224696746
  
    --- Diff: src/java/org/apache/cassandra/config/Config.java ---
    @@ -238,6 +238,7 @@
         public int hints_flush_period_in_ms = 10000;
         public int max_hints_file_size_in_mb = 128;
         public ParameterizedClass hints_compression;
    +    public boolean invalidate_cache_on_compaction = true;
    --- End diff --
    
    The biggest performance impact of setting this to `false` is probably not the fact that we don't invalidate the cache anymore, but that we don't warm the cache up for the new sstables - maybe we should rename the property? (warm_keycache_on_compaction or migrate_keycache_on_compaction?) Or at least add a comment about it? And it should probably say "keycache" instead of "cache"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org