You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Bruce Mitchener (JIRA)" <ji...@apache.org> on 2010/03/02 12:03:27 UTC
[jira] Created: (AVRO-442) sizeof void* and sizeof long detected at
configure time
sizeof void* and sizeof long detected at configure time
-------------------------------------------------------
Key: AVRO-442
URL: https://issues.apache.org/jira/browse/AVRO-442
Project: Avro
Issue Type: Sub-task
Components: c
Affects Versions: 1.3.0
Reporter: Bruce Mitchener
configure.in includes this:
AC_CHECK_SIZEOF(void *)
AC_CHECK_SIZEOF(long)
Which is used in st.h:
#if SIZEOF_LONG == SIZEOF_VOID_P
typedef unsigned long st_data_t;
#elif SIZEOF_LONG_LONG == SIZEOF_VOID_P
typedef unsigned LONG_LONG st_data_t;
#else
#error ---->> st.c requires sizeof(void*) == sizeof(long) to be compiled. <<---
#endif
#define ST_DATA_T_DEFINED
Couldn't that just be uintptr_t or something else and avoid the configure check entirely?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AVRO-442) sizeof void* and sizeof long detected
at configure time
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie reassigned AVRO-442:
--------------------------------
Assignee: Matt Massie
> sizeof void* and sizeof long detected at configure time
> -------------------------------------------------------
>
> Key: AVRO-442
> URL: https://issues.apache.org/jira/browse/AVRO-442
> Project: Avro
> Issue Type: Sub-task
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Assignee: Matt Massie
> Attachments: avro_no_size_checks.diff
>
>
> configure.in includes this:
> AC_CHECK_SIZEOF(void *)
> AC_CHECK_SIZEOF(long)
> Which is used in st.h:
> #if SIZEOF_LONG == SIZEOF_VOID_P
> typedef unsigned long st_data_t;
> #elif SIZEOF_LONG_LONG == SIZEOF_VOID_P
> typedef unsigned LONG_LONG st_data_t;
> #else
> #error ---->> st.c requires sizeof(void*) == sizeof(long) to be compiled. <<---
> #endif
> #define ST_DATA_T_DEFINED
> Couldn't that just be uintptr_t or something else and avoid the configure check entirely?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-442) sizeof void* and sizeof long detected at
configure time
Posted by "Bruce Mitchener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruce Mitchener updated AVRO-442:
---------------------------------
Attachment: avro_no_size_checks.diff
The attached patch just uses uintptr_t instead of doing configure checks...
> sizeof void* and sizeof long detected at configure time
> -------------------------------------------------------
>
> Key: AVRO-442
> URL: https://issues.apache.org/jira/browse/AVRO-442
> Project: Avro
> Issue Type: Sub-task
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_no_size_checks.diff
>
>
> configure.in includes this:
> AC_CHECK_SIZEOF(void *)
> AC_CHECK_SIZEOF(long)
> Which is used in st.h:
> #if SIZEOF_LONG == SIZEOF_VOID_P
> typedef unsigned long st_data_t;
> #elif SIZEOF_LONG_LONG == SIZEOF_VOID_P
> typedef unsigned LONG_LONG st_data_t;
> #else
> #error ---->> st.c requires sizeof(void*) == sizeof(long) to be compiled. <<---
> #endif
> #define ST_DATA_T_DEFINED
> Couldn't that just be uintptr_t or something else and avoid the configure check entirely?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-442) sizeof void* and sizeof long detected
at configure time
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie resolved AVRO-442.
------------------------------
Resolution: Fixed
Thanks for the patch, Bruce. Committed to trunk.
> sizeof void* and sizeof long detected at configure time
> -------------------------------------------------------
>
> Key: AVRO-442
> URL: https://issues.apache.org/jira/browse/AVRO-442
> Project: Avro
> Issue Type: Sub-task
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Assignee: Matt Massie
> Attachments: avro_no_size_checks.diff
>
>
> configure.in includes this:
> AC_CHECK_SIZEOF(void *)
> AC_CHECK_SIZEOF(long)
> Which is used in st.h:
> #if SIZEOF_LONG == SIZEOF_VOID_P
> typedef unsigned long st_data_t;
> #elif SIZEOF_LONG_LONG == SIZEOF_VOID_P
> typedef unsigned LONG_LONG st_data_t;
> #else
> #error ---->> st.c requires sizeof(void*) == sizeof(long) to be compiled. <<---
> #endif
> #define ST_DATA_T_DEFINED
> Couldn't that just be uintptr_t or something else and avoid the configure check entirely?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-442) sizeof void* and sizeof long detected at
configure time
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie updated AVRO-442:
-----------------------------
Assignee: (was: Matt Massie)
> sizeof void* and sizeof long detected at configure time
> -------------------------------------------------------
>
> Key: AVRO-442
> URL: https://issues.apache.org/jira/browse/AVRO-442
> Project: Avro
> Issue Type: Sub-task
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_no_size_checks.diff
>
>
> configure.in includes this:
> AC_CHECK_SIZEOF(void *)
> AC_CHECK_SIZEOF(long)
> Which is used in st.h:
> #if SIZEOF_LONG == SIZEOF_VOID_P
> typedef unsigned long st_data_t;
> #elif SIZEOF_LONG_LONG == SIZEOF_VOID_P
> typedef unsigned LONG_LONG st_data_t;
> #else
> #error ---->> st.c requires sizeof(void*) == sizeof(long) to be compiled. <<---
> #endif
> #define ST_DATA_T_DEFINED
> Couldn't that just be uintptr_t or something else and avoid the configure check entirely?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.