[GitHub] [lucene] mocobeta commented on a diff in pull request #893: LUCENE-10531: Run GUI tests on CI only

[GitBox <gi...@apache.org>]

mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873963691


##########
lucene/distribution.tests/build.gradle:
##########
@@ -50,10 +50,15 @@ test {
   jvmArgumentProviders.add(new CommandLineArgumentProvider() {
     @Override
     Iterable<String> asArguments() {
-      return [
+      var args = [
           "-Dlucene.distribution.dir=${configurations.binaryDistribution.singleFile.absolutePath }",
           "-Dlucene.distribution.version=${project.version}"
       ]
+      if (isCIBuild) {
+        // force to run GUI tests
+        args += ["-Dtests.gui=true"]
+      }

Review Comment:
   I simply use `isCIBuild` variable that was introduced in #890; this might be hacky?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org