You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/12/11 20:50:59 UTC

[PR] SemanticHighlighter support for context sensitive value keyword [netbeans]

mbien opened a new pull request, #9079:
URL: https://github.com/apache/netbeans/pull/9079

   works only when combined with a valhalla build of javac (e.g: uninstall nb-javac and run NB on the valhalla build)
   
   Thats also why there is no unit test.
   
   The other commit is code cleanup in the `semantic` package.
   
   
   <img width="618" height="447" alt="image" src="https://github.com/user-attachments/assets/6a82e721-5694-48c4-8d42-d7fa5b95a2ee" />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] SemanticHighlighter support for context sensitive value keyword [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9079:
URL: https://github.com/apache/netbeans/pull/9079#discussion_r2612057153


##########
java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java:
##########
@@ -979,7 +985,7 @@ record = true;
                 if (permitList != null && !permitList.isEmpty()) {
                     tl.moveNext();
                     Token<?> t = firstIdentifierToken("permits");// NOI18N
-                    if (tl != null) {
+                    if (t != null) {
                         contextKeywords.add(t);
                         scan(permitList, null);
                     }

Review Comment:
   looked like bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] SemanticHighlighter support for context sensitive value keyword [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9079:
URL: https://github.com/apache/netbeans/pull/9079#issuecomment-3663134503

   just a rebase for new dev build


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] SemanticHighlighter support for context sensitive value keyword [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9079:
URL: https://github.com/apache/netbeans/pull/9079#issuecomment-3663376028

   manual test worked, added instructions under the issue https://github.com/apache/netbeans/issues/8994#issuecomment-3663367910
   
   thanks for review, merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] SemanticHighlighter support for context sensitive value keyword [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #9079:
URL: https://github.com/apache/netbeans/pull/9079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists