[jira] [Closed] (HBASE-4466) Fix accounting of the number of blocks read for the one-level index case

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-4466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell closed HBASE-4466.
--------------------------------------

> Fix accounting of the number of blocks read for the one-level index case
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4466
>                 URL: https://issues.apache.org/jira/browse/HBASE-4466
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Mikhail Gryzykhin
>            Priority: Major
>
> In HFileBlockIndex.seekToDataBlock if the current block is the same as the requested block, then in the 1-level index case, we were read block from cache again. Although this would be a cache hit, it unnecessarily increases the block cache read count and block cache hit count, and also makes it harder to keep the accounting straight for tests like TestBlocksRead (introduced in HBASE-4450).
> Basically, even in the 1-level index case, in HFileBlockIndex.seekToDataBlock(), if currentBlock.getOffset() == currentOffset, we can avoid looking up the block in cache. 
> Assigning to Mikhail (he's already fixed this in our internal branch).



--
This message was sent by Atlassian Jira
(v8.20.7#820007)