You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/23 03:42:31 UTC
[GitHub] [pulsar] freeznet opened a new pull request #12145: [pulsar-io] pass client builder if no service url provided with debezium connector
freeznet opened a new pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145
### Motivation
#11293 allows to passing client builder to debezium database history, but it still requires passing `database.history.pulsar.service.url` as well. With client builder, the `database.history.pulsar.service.url` is not been used anymore.
This PR fixes the logic and only pass client builder with no `database.history.pulsar.service.url` provided.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] doc-required
(If you need help on updating docs, create a doc issue)
- [x] no-need-doc
internal bug fix
- [ ] doc
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-972542295
@nlu90 please help to review this when you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-925551213
@dlg99 please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-1022846609
@freeznet Could you please create a PR for 2.8 and 2.9 directly? There is some conflict when cherry-picking into 2.8 and 2.9 branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-972542143
@eolivelli sorry for the late reply, I have modified the integration tests, PTAL when you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-972649450
@nicoloboschi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12145:
URL: https://github.com/apache/pulsar/pull/12145#issuecomment-1024869553
@codelipenghui added #14040 and #14041 to add this into 2.8 and 2.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org