You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/12 17:46:34 UTC

[kudu-CR] [examples] Add a complete Spark quickstart example

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13852


Change subject: [examples] Add a complete Spark quickstart example
......................................................................

[examples] Add a complete Spark quickstart example

This patchs adds a brief example using Apache Spark to
load, query, and modify a real data set in Apache Kudu.

It also updates the quickstart docs to point to the
examples directory.

Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
---
M docs/quickstart.adoc
A examples/quickstart/spark/README.adoc
2 files changed, 217 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/13852/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................

[examples] Add a complete Spark quickstart example

This patchs adds a brief example using Apache Spark to
load, query, and modify a real data set in Apache Kudu.

It also updates the quickstart docs to point to the
examples directory.

Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Reviewed-on: http://gerrit.cloudera.org:8080/13852
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M docs/quickstart.adoc
A examples/quickstart/spark/README.adoc
2 files changed, 217 insertions(+), 2 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Grant Henke: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13852/1/examples/quickstart/spark/README.adoc
File examples/quickstart/spark/README.adoc:

http://gerrit.cloudera.org:8080/#/c/13852/1/examples/quickstart/spark/README.adoc@17
PS1, Line 17: Note:
I think if we want this to render as a note (like in https://github.com/andrwng/kudu/blob/hms-docs/docs/hive_metastore.adoc), this needs to be NOTE: (same elsewhere)



-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 13 Jul 2019 00:41:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13852

to look at the new patch set (#2).

Change subject: [examples] Add a complete Spark quickstart example
......................................................................

[examples] Add a complete Spark quickstart example

This patchs adds a brief example using Apache Spark to
load, query, and modify a real data set in Apache Kudu.

It also updates the quickstart docs to point to the
examples directory.

Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
---
M docs/quickstart.adoc
A examples/quickstart/spark/README.adoc
2 files changed, 217 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/13852/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13852/1/examples/quickstart/spark/README.adoc
File examples/quickstart/spark/README.adoc:

http://gerrit.cloudera.org:8080/#/c/13852/1/examples/quickstart/spark/README.adoc@17
PS1, Line 17: Note:
> I think if we want this to render as a note (like in https://github.com/and
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 14 Jul 2019 23:22:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 12 Jul 2019 18:31:30 +0000
Gerrit-HasComments: No

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 14 Jul 2019 23:27:02 +0000
Gerrit-HasComments: No

[kudu-CR] [examples] Add a complete Spark quickstart example

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13852 )

Change subject: [examples] Add a complete Spark quickstart example
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30a9827d96197c50bce844ac1250033c7003c9c
Gerrit-Change-Number: 13852
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 14 Jul 2019 23:26:38 +0000
Gerrit-HasComments: No