You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/04 19:06:29 UTC

[jira] [Commented] (HIVE-2319) Calling alter_table after changing partition comment throws an exception

    [ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079470#comment-13079470 ] 

jiraposter@reviews.apache.org commented on HIVE-2319:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1213/
-----------------------------------------------------------

(Updated 2011-08-04 17:05:08.413032)


Review request for hive and Paul Yang.


Changes
-------

Removed a change in TestMetaStoreEventListener.java that somehow snuck in this diff.


Summary
-------

Altering a table's partition key comments raises an InvalidOperationException. The partition key name and type should not be mutable, but the comment should be able to get changed.


This addresses bug HIVE-2319.
    https://issues.apache.org/jira/browse/HIVE-2319


Diffs (updated)
-----

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1153927 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1153927 

Diff: https://reviews.apache.org/r/1213/diff


Testing
-------

Added some test cases to HiveMetaStore that pass.


Thanks,

Sohan



> Calling alter_table after changing partition comment throws an exception
> ------------------------------------------------------------------------
>
>                 Key: HIVE-2319
>                 URL: https://issues.apache.org/jira/browse/HIVE-2319
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Sohan Jain
>            Assignee: Sohan Jain
>         Attachments: HIVE-2319.2.patch, HIVE-2319.3.patch
>
>
> Altering a table's partition key comments raises an InvalidOperationException.  The partition key name and type should not be mutable, but the comment should be able to get changed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira