You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/12 13:28:52 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #3048: Support to specify the client ip address for interactive session
turboFei opened a new pull request, #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3048: Support to get the real client ip address when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r919590995
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiReservedKeys.scala:
##########
@@ -19,6 +19,7 @@ package org.apache.kyuubi.config
object KyuubiReservedKeys {
final val KYUUBI_SESSION_USER_KEY = "kyuubi.session.user"
+ final val KYUUBI_SESSION_IP_KEY = "kyuubi.session.ip"
Review Comment:
we have `kyuubi.client.ip` already, how about using this?
maybe kyuubi.client.ipAddress is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3048: Support to get the real client ip address when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r919615236
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiReservedKeys.scala:
##########
@@ -19,6 +19,7 @@ package org.apache.kyuubi.config
object KyuubiReservedKeys {
final val KYUUBI_SESSION_USER_KEY = "kyuubi.session.user"
+ final val KYUUBI_SESSION_IP_KEY = "kyuubi.session.ip"
Review Comment:
thanks for the information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182896641
> for authentication, this introduces a CVE
Seems difficult to avoid it....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182869112
for authentication, this introduce a CVE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r964928626
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
protocol: TProtocolVersion,
user: String,
password: String,
- serverIpAddress: String,
Review Comment:
[SparkSessionImpl.scala#L51](https://github.com/turboFei/incubator-kyuubi/blob/97f9b00417f211cc547998821ba421b15edb6c76/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala#L51) becomes redundant, thanks, I will remove it.
```
def serverIpAddress(): String = serverIpAddress
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
URL: https://github.com/apache/incubator-kyuubi/pull/3048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1183055497
if we just want to track the IP, not for authentication, we may just leave it in the configuration and get it whenever we want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r919741380
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/package.scala:
##########
@@ -28,5 +28,5 @@ package object session {
val SPARK_PREFIX = "spark."
- val CLIENT_IP_KEY = "kyuubi.client.ip"
Review Comment:
move it to reserved keys class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182753944
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3048](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (875c981) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/1bc3916d99976baa126ab46a15a9c3ebd3088f8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bc3916) will **increase** coverage by `1.05%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #3048 +/- ##
============================================
+ Coverage 50.44% 51.49% +1.05%
Complexity 6 6
============================================
Files 454 453 -1
Lines 25480 25166 -314
Branches 3576 3507 -69
============================================
+ Hits 12854 12960 +106
+ Misses 11406 10970 -436
- Partials 1220 1236 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlDb25uZWN0aW9uLmphdmE=) | `4.14% <0.00%> (+0.01%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `90.93% <75.00%> (-0.22%)` | :arrow_down: |
| [...main/scala/org/apache/kyuubi/session/package.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL3BhY2thZ2Uuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
| [...uubi/engine/spark/events/SparkOperationEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9ldmVudHMvU3BhcmtPcGVyYXRpb25FdmVudC5zY2FsYQ==) | `88.88% <0.00%> (-5.56%)` | :arrow_down: |
| [...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xvZy9Mb2dCYXRjaENvbW1hbmQuc2NhbGE=) | `80.00% <0.00%> (-2.00%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `80.82% <0.00%> (-1.37%)` | :arrow_down: |
| [...g/apache/kyuubi/server/KinitAuxiliaryService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS2luaXRBdXhpbGlhcnlTZXJ2aWNlLnNjYWxh) | `65.78% <0.00%> (-0.88%)` | :arrow_down: |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.23% <0.00%> (-0.84%)` | :arrow_down: |
| [...he/kyuubi/jdbc/hive/ZooKeeperHiveClientHelper.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9ab29LZWVwZXJIaXZlQ2xpZW50SGVscGVyLmphdmE=) | `2.88% <0.00%> (-0.76%)` | :arrow_down: |
| [...rc/main/scala/org/apache/spark/ui/EnginePage.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3BhcmsvdWkvRW5naW5lUGFnZS5zY2FsYQ==) | `78.86% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1bc3916...875c981](https://codecov.io/gh/apache/incubator-kyuubi/pull/3048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182954863
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182926527
> In fact, now with the proxy lb, the client ip address is also not the real ip and maybe not in the ip white list.
that’s lb's duty..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r964128135
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
protocol: TProtocolVersion,
user: String,
password: String,
- serverIpAddress: String,
Review Comment:
this change may breaks https://github.com/apache/incubator-kyuubi/pull/1530/files#diff-759a09fe90c07b0ef78f6f4dc28bac9e3d0785d4b922cbe33422524e8a2520d4R51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1185114458
It will be overwritten here:
https://github.com/apache/incubator-kyuubi/blob/99934591f07be5bc8abc1955848e4fc291b8569b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala#L60-L65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1183174213
has chatted with kent offline.
Now the KYUUBI_CLIENT_IP does not take affect during authentication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1185295688
thanks for the patience, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1185113592
> if we just want to track the IP, not for authentication, we may just leave it in the configuration and get it whenever we want
How about that,
we define another reserved key for this?
Otherwise, the kyuubi.client.ip will be overwrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1182913843
In fact, now with the proxy lb, the client ip address is also not the real ip and maybe not in the ip white list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#issuecomment-1185225491
thank a lot @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r964128135
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
protocol: TProtocolVersion,
user: String,
password: String,
- serverIpAddress: String,
Review Comment:
this change may break https://github.com/apache/incubator-kyuubi/pull/1530/files#diff-759a09fe90c07b0ef78f6f4dc28bac9e3d0785d4b922cbe33422524e8a2520d4R51
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
protocol: TProtocolVersion,
user: String,
password: String,
- serverIpAddress: String,
Review Comment:
cc @turboFei @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org