You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/20 15:26:28 UTC
[GitHub] [airflow] janarthanandev opened a new pull request #17756: Fix "Invalid JSON configuration, must be a dict"
janarthanandev opened a new pull request #17756:
URL: https://github.com/apache/airflow/pull/17756
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17756:
URL: https://github.com/apache/airflow/pull/17756#issuecomment-903274667
I don’t understand. 2.1.1 is already out so we can’t just change the code. We need to release a new version, and that is 2.1.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17756:
URL: https://github.com/apache/airflow/pull/17756#issuecomment-902806902
@janarthanandev, it looks to me like this change was actually cherry-picked to 2.1.2. Your `v2-1-stable` branch is behind. I also see `v2.1.1` in the footer of your screenshot.
Some links -
The cherry-pick commit: https://github.com/apache/airflow/commit/4c1abfbe0966969929f32a2adc57e9835bac9312
`2.1.2` tag: https://github.com/apache/airflow/blob/2.1.2/airflow/www/views.py#L1513
HEAD of `v2-1-stable`: https://github.com/apache/airflow/blob/2b80c1edec85fb2b0312b6ae7f415c6f744e322e/airflow/www/views.py#L1514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17756:
URL: https://github.com/apache/airflow/pull/17756#issuecomment-902773577
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #17756:
URL: https://github.com/apache/airflow/pull/17756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] janarthanandev commented on pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
janarthanandev commented on pull request #17756:
URL: https://github.com/apache/airflow/pull/17756#issuecomment-903252825
> @janarthanandev, it looks to me like this change was actually cherry-picked to 2.1.2. Your `v2-1-stable` branch is behind. I also see `v2.1.1` in the footer of your screenshot.
>
> Some links -
> The cherry-pick commit: [4c1abfb](https://github.com/apache/airflow/commit/4c1abfbe0966969929f32a2adc57e9835bac9312)
> `2.1.2` tag: https://github.com/apache/airflow/blob/2.1.2/airflow/www/views.py#L1513
> HEAD of `v2-1-stable`:
>
> https://github.com/apache/airflow/blob/2b80c1edec85fb2b0312b6ae7f415c6f744e322e/airflow/www/views.py#L1514
hi @jedcunningham Yes, it's true we are recently migrated 2.1.1 version and it's tough to migrate again 2.1.2. so only we are requesting for fix in 2.1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] janarthanandev commented on pull request #17756: Fix "Invalid JSON configuration, must be a dict"
Posted by GitBox <gi...@apache.org>.
janarthanandev commented on pull request #17756:
URL: https://github.com/apache/airflow/pull/17756#issuecomment-902788306
hi @kaxil @uranusjr @msumit , These issue was fixed in 2.1.2 but doesn't backported to 2.1.2, so creating pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org