You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2014/03/19 01:51:40 UTC
Remove tools/buildbot from tarballs?
Ben Reser <be...@reser.org> writes:
> The 1.9.0-alpha2 release artifacts are now available for testing/signing.
Is it worth stripping tools/buildbot from the tarball? The files are no
real use in the tarball but they are not very big either, perhaps 12KB
in the tarball and 248KB unpacked.
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Re: Remove tools/buildbot from tarballs?
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Mar 19, 2014 at 12:51:40AM +0000, Philip Martin wrote:
> Ben Reser <be...@reser.org> writes:
>
> > The 1.9.0-alpha2 release artifacts are now available for testing/signing.
>
> Is it worth stripping tools/buildbot from the tarball?
+1 I don't think anyone compiling from a tarball needs these files.
Index: tools/dist/dist.sh
===================================================================
--- tools/dist/dist.sh (revision 1578108)
+++ tools/dist/dist.sh (working copy)
@@ -228,6 +228,12 @@ ver_major=`echo $VERSION | cut -d '.' -f 1`
ver_minor=`echo $VERSION | cut -d '.' -f 2`
ver_patch=`echo $VERSION | cut -d '.' -f 3`
+# Remove tools/dev/buildbot from our distribution tarball.
+# End users cannot really do anything with these files.
+if [ "$ver_major" -eq "1" -a "$ver_minor" -ge "9" ]; then
+ rm -rf "$DISTPATH/tools/buildbot"
+fi
+
# Remove contrib/ from our distribution tarball. Some of it is of
# unknown license, and usefulness.
# (See http://svn.haxx.se/dev/archive-2009-04/0166.shtml for discussion.)
Re: Remove tools/buildbot from tarballs?
Posted by Julian Foad <ju...@btopenworld.com>.
Philip Martin wrote:
> Is it worth stripping tools/buildbot from the tarball? The files are no
> real use in the tarball but they are not very big either, perhaps 12KB
> in the tarball and 248KB unpacked.
It seems a bit ugly to be selectively including and excluding parts of the 'tools' directory.
This idea suggests to me that 'tools/' is not the right place for the buildbot config. Perhaps they should go in a higher-level directory. Even outside the trunk/branches/tags directories, since the complete set of buildbot configs should not be specific to one branch of the source code but rather should be a single set of configurations that handle all currently interesting trunks/tags/branches.
(The same argument may apply to any scripts we have for building / releasing / packaging / testing / signing, that are used for multiple branches.)
- Julian