You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/10 18:07:38 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26324: Convert all airflow tests to __future__.annotations
potiuk opened a new pull request, #26324:
URL: https://github.com/apache/airflow/pull/26324
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26324: Convert all airflow tests to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26324:
URL: https://github.com/apache/airflow/pull/26324#discussion_r968268094
##########
.pre-commit-config.yaml:
##########
@@ -213,7 +213,9 @@ repos:
- id: pyupgrade
name: Upgrade Python code automatically
args: ["--py37-plus"]
- exclude: ^airflow/_vendor/
+ # Test Python tests if different kinds of typing including one that does not have
+ # __future__ annotations, so it shuld be left without automated upgrade
+ exclude: ^airflow/_vendor/|^test/decorators/test_python.py^
Review Comment:
Because it checks in runtime the type of annotation used and explicitly wants to use Dict which otherwise would be removed by pyupgrade (pyupgrade is not very configurable and I could not find a way to exclude specific lines from pyupgrade checks - I only know how to exclude the whole file. The test in question is this:
```
@pytest.mark.parametrize(
"annotation",
[
"dict",
pytest.param(
"dict[str, int]",
marks=pytest.mark.skipif(
sys.version_info < (3, 9),
reason="PEP 585 is implemented in Python 3.9",
),
),
"Dict",
"Dict[str, int]",
],
)
def test_infer_multiple_outputs_using_dict_typing(self, resolve, annotation):
```
I think I even tried to replace`Dict` by `dict` in this case and it did not work out-of-the-box, so for the sake of "as small and as safe change as possible" I decided to exclude the whole file from pyupgrade and add appropriate comments (I did it after Pyupgrade already made changes, just backed-out the Dict changes.
There is even a comment at the top mentioning it:
```
from typing import Dict # noqa: F401 # This is used by annotation tests.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26324: Convert all airflow tests to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26324:
URL: https://github.com/apache/airflow/pull/26324#issuecomment-1245283435
Closing as this one will be merged as part of #26289 #26290. See https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26324: Convert all airflow tests to __future__.annotations
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26324:
URL: https://github.com/apache/airflow/pull/26324#discussion_r968260433
##########
.pre-commit-config.yaml:
##########
@@ -213,7 +213,9 @@ repos:
- id: pyupgrade
name: Upgrade Python code automatically
args: ["--py37-plus"]
- exclude: ^airflow/_vendor/
+ # Test Python tests if different kinds of typing including one that does not have
+ # __future__ annotations, so it shuld be left without automated upgrade
+ exclude: ^airflow/_vendor/|^test/decorators/test_python.py^
Review Comment:
Can you explain (here, not comment) why this decorator can't have the annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #26324: Convert all airflow tests to __future__.annotations
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #26324: Convert all airflow tests to __future__.annotations
URL: https://github.com/apache/airflow/pull/26324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org