You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/02 20:05:12 UTC

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8713: Split functionality out of views/database/__init__.py, re-enable pylint

betodealmeida commented on a change in pull request #8713: Split functionality out of views/database/__init__.py, re-enable pylint
URL: https://github.com/apache/incubator-superset/pull/8713#discussion_r352801678
 
 

 ##########
 File path: superset/views/database/views.py
 ##########
 @@ -14,40 +14,37 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-# pylint: disable=C,R,W
 import os
 
 from flask import flash, g, redirect
 from flask_appbuilder import SimpleFormView
-from flask_appbuilder.forms import DynamicForm
 from flask_appbuilder.models.sqla.interface import SQLAInterface
 from flask_babel import gettext as __, lazy_gettext as _
-from sqlalchemy.exc import IntegrityError
 from werkzeug.utils import secure_filename
 from wtforms.fields import StringField
 from wtforms.validators import ValidationError
 
 import superset.models.core as models
-from superset import app, appbuilder, db, security_manager
+from superset import app, appbuilder, db # , security_manager
 
 Review comment:
   Remove `security_manager`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org