You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/06/19 02:41:45 UTC
[jira] Created: (THRIFT-40) Make the compiler respond to --version
Make the compiler respond to --version
--------------------------------------
Key: THRIFT-40
URL: https://issues.apache.org/jira/browse/THRIFT-40
Project: Thrift
Issue Type: Sub-task
Components: Compiler (General)
Reporter: Bryan Duxbury
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-40:
--------------------------------
Attachment: thrift-40.patch
Here's the very minimal work I've done so far. If it's useless, don't feel bad scrapping it.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606173#action_12606173 ]
David Reiss commented on THRIFT-40:
-----------------------------------
I would change this in a few ways. At the very least, we should make use of the version in configure.ac instead of creating a new VERSION file. It *might* also be worth using the configure script to substitute the last release version into version.h. Also, I know I suggested using bootstrap.sh for this, but I wonder if it might be worth doing it before every make.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609389#action_12609389 ]
David Reiss commented on THRIFT-40:
-----------------------------------
Sloppy. Applying now.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: Kevin Ballard
> Attachments: 0001--THRIFT-40-Remove-stray-n-s-from-the-generated-ver.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Johan Stuyts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609391#action_12609391 ]
Johan Stuyts commented on THRIFT-40:
------------------------------------
It is working again. Thanks.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: Kevin Ballard
> Attachments: 0001--THRIFT-40-Remove-stray-n-s-from-the-generated-ver.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608616#action_12608616 ]
David Reiss commented on THRIFT-40:
-----------------------------------
Nice catch on the tempfile. Pushed an update (first url will show the new one, second url is still the old one.)
Well, if git does it, it can't be that bad. :) I'm still a little skeptical that adding an extra file and then adding an exec in the AC_INIT is simpler than adding a single sed command to print_version.sh, but if other people weigh in on this, I'm open to opinions.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Johan Stuyts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609384#action_12609384 ]
Johan Stuyts commented on THRIFT-40:
------------------------------------
I just tried to compile the trunk on Debian Etch and got:
src/main.cc:597: error: stray '\' in program
This is the 'version()' function.
'version.h' contains the following:
{code:none}
// AUTOGENERATED, DO NOT EDIT
#define THRIFT_VERSION "20080411"\n
#define THRIFT_REVISION "r672943M"\n
{code}
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: Kevin Ballard
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606453#action_12606453 ]
Bryan Duxbury commented on THRIFT-40:
-------------------------------------
I don't have any objection to using the version from configure.ac. I think we should use a different versioning scheme than date stamps, though. Can configure.ac's version be whatever we want? How do we access the version number in configure.ac? Just parse it out of the file manually, or is there some more acceptable way?
I think using make to do the substitution is just fine. I don't current speak make, though, so pointers would be appreciated.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Attachment: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch
New version of the patch, this one doesn't accidentally include the generated compiler/cpp/src/version.h file
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Attachment: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch
The given patch (suitable for use with git-am) implements the -version switch. It also provides a toplevel print_version.sh script (used to generate src/version.h) that client libraries can use if they want to embed the compiler version.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608252#action_12608252 ]
David Reiss commented on THRIFT-40:
-----------------------------------
This is great work. I'd like to request a few changes, though.
1/ Please use configure.ac as the authoritative source for the latest release. (It is the second param ot AC_INIT.)
2/ Please use $(topsrcdir) instead of ../.. in Makefile.am. (I'm not 100% sure if it will work in this context, but if it doesn't then we need to find another solution.)
3/ please use argv[i] in "you have a right" check for consistency with the error check below.
4/ Please put a comment explaining why version.h is declare phony even though it is not.
My intuition is that the version might not always be updated properly on an svn up. It would be good if we could figure out how to solve this, but for now I am fine with the current rebuild strategy.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Attachment: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch
# I can certainly mess with configure.ac to embed the version in there, but I can't use that as the source for the version as that only gets rebuilt when ./bootstrap.sh is called. If we look at other projects like macports or git, they embed the current version when autoconf is called, but certainly don't rely on that as the source for their version.
# $(topsrcdir) doesn't work. It doesn't seem to be defined in this context. I'll leave it as ../.. unless you have a better suggestion.
# I have no idea what you mean.
# Done.
The version is recalculated every time you run `make`. So yes, it only documents the compiler version, but that's what it's supposed to do.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-40) Make the compiler respond to --version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss reassigned THRIFT-40:
---------------------------------
Assignee: Kevin Ballard (was: David Reiss)
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: Kevin Ballard
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608600#action_12608600 ]
Kevin Ballard commented on THRIFT-40:
-------------------------------------
As I mentioned earlier, both macports and git (which are autoconf-based projects) have configure.ac pull in the version from an external source. I don't see the point in making configure.ac embed the raw string and having something else have to parse that file when it really is simpler to just have a VERSION file.
In any case, your patch would be acceptable. I should point out that if the generated version.h file is identical to the old one, you don't bother rm'ing the tempfile.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608558#action_12608558 ]
Kevin Ballard commented on THRIFT-40:
-------------------------------------
# Except configure.ac can't embed the version that print_version.sh reports. What it *could* embed is the v0.0.1 version, but it's a lot simpler to have a VERSION file for that. configure.ac could embed that VERSION file rather than embedding the full output of print_version.sh if you want, but I don't see how that would be any better. With the new patch, configure.ac asks print_version.sh for the current version. This does mean it's only recalculated when you run ./bootstrap.sh, but there doesn't seem to be any way around that.
Recompiling main.cc isn't so bad, and there's really no way to avoid it unless we want to make version.h actually be version.c and embed functions instead of #defines. And that would have to be recompiled on every run anyway.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606172#action_12606172 ]
Bryan Duxbury commented on THRIFT-40:
-------------------------------------
Proposal:
* create a version.h that defines the version constant
* create a VERSION file at the root that contains the version number
* bootstrap.sh should edit version.h automatically to copy value from VERSION and svn rev number to version.h
* add handler for --version switch to print version number
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Patch Info: [Patch Available]
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608555#action_12608555 ]
David Reiss commented on THRIFT-40:
-----------------------------------
1/ configure.ac is not a generated file. It is part of the source tree, and it already contains the authoritative version (20080411). I think print_version.sh should pull the version out of configure.ac rather than the other way around.
2/ I'll poke around with this. We've already been yelled at once for not supporting out-of-source builds.
3/ Actually, never mind about this one.
I was actually thinking that make would only rebuild the compiler when main.cc changed, but I was thinking about the dependencies wrong. I wish we could avoid all this unnecessary recompilation. I'm going to take a stab at this.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Attachment: (was: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch)
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608090#action_12608090 ]
Doug Cutting commented on THRIFT-40:
------------------------------------
The best practice with Jira is not to delete old attachments but rather to overwrite them with a new file of the same name. That way the old version is still available for posterity. Similarly, deleting and editing comments is discouraged. Rather, if you make a mistake, add a new comment correcting it. These practices make it easier for folks to follow an issue retrospectively.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-40) Make the compiler respond to --version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ballard updated THRIFT-40:
--------------------------------
Attachment: 0001--THRIFT-40-Remove-stray-n-s-from-the-generated-ver.patch
David, when you converted my printf's to echo's, you forgot to remove the \n. It seems those get interpreted as newlines on your system and on mine (which is why we didn't notice), but it breaks on Johan's system. I've just attached a patch to fix this.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: Kevin Ballard
> Attachments: 0001--THRIFT-40-Remove-stray-n-s-from-the-generated-ver.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606484#action_12606484 ]
Kevin Clark commented on THRIFT-40:
-----------------------------------
Is this something we'd want to make accessible from the language bindings, or are we mostly concerned with being able to do `thrift --version` ?
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (THRIFT-40) Make the compiler respond to --version
Posted by Doug Cutting <cu...@apache.org>.
David Reiss (JIRA) wrote:
> Assignee: David Reiss
The convention I've used on other projects is to use the "Assignee"
field to note the primary author of the patch. This makes it easier to
identify new potential committers. Jira's "Contribution Report" (on the
upper right of the project page) is useful here, as is the "Assigned
(All | ...)" button in a user's profile.
http://tinyurl.com/5x8tb7
http://tinyurl.com/4jpuex
Doug
[jira] Resolved: (THRIFT-40) Make the compiler respond to --version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-40.
-------------------------------
Resolution: Fixed
Assignee: David Reiss
Well, no one else seems to have an opinion on this, so I just committed the current version. If people want to re-open this discussion, that's fine.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Assignee: David Reiss
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606486#action_12606486 ]
Bryan Duxbury commented on THRIFT-40:
-------------------------------------
I think both. First step is the compiler part though.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608595#action_12608595 ]
David Reiss commented on THRIFT-40:
-----------------------------------
Yeah, I just meant to replace VERSION with the version in configure.ac. I think it is simpler to have configure.ac be the authoritative source for this (like every other autoconf-based project), rather than creating an extra file for it. I don't think we should try to include the full svn/git version information in configure.ac. It is only used for make dist, afaik, which we will only be using on releases.
I have another solution for main.cc. It never recompiles the compiler unnecessarily, but it doesn't update the version if you run "make thrift" instead of "make". I think this is a good compromise. What do you think?
Incremental changes: http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/version;hb=HEAD
Full diff: http://gitweb.thrift-rpc.org/?p=thrift.git;a=treediff;h=5809c82;hp=c1339c0
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
> Attachments: 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch, thrift-40.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "Kevin Ballard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606175#action_12606175 ]
Kevin Ballard commented on THRIFT-40:
-------------------------------------
Doing it on each make sounds like a good idea, because I expect most people who keep a persistent source repo to call bootstrap.sh once and never touch it again.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-40) Make the compiler respond to
--version
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606509#action_12606509 ]
David Reiss commented on THRIFT-40:
-----------------------------------
I'll take a shot at this over the weekend. I've gotten pretty good at reading the autoconf docs.
> Make the compiler respond to --version
> --------------------------------------
>
> Key: THRIFT-40
> URL: https://issues.apache.org/jira/browse/THRIFT-40
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.