You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by matthiasblaesing <gi...@git.apache.org> on 2017/09/30 20:27:15 UTC

[GitHub] incubator-netbeans pull request #29: [NETBEANS-54] Module Review derby

GitHub user matthiasblaesing opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/29

    [NETBEANS-54] Module Review derby

    - external binary is binary form of etc/sample.sql (not on maven)
    
    - checked Rat report; missing header added to etc/sample.sql, ignored
      binaries-list and *.form files (see central problems)
    
    - skimmed through the module, did not notice additional problems
    
    - replacing the bundled binary is tracked by [NETBEANS-74]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matthiasblaesing/incubator-netbeans derby-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit 3d3a135eceb1fc820d08996890fe743c9a037fa8
Author: Matthias Bläsing <mb...@doppel-helix.eu>
Date:   2017-09-30T20:21:57Z

    [NETBEANS-54] Module Review derby
    
    - external binary is binary form of etc/sample.sql (not on maven)
    
    - checked Rat report; missing header added to etc/sample.sql, ignored
      binaries-list and *.form files (see central problems)
    
    - skimmed through the module, did not notice additional problems
    
    - replacing the bundled binary is tracked by [NETBEANS-74]

----


---

[GitHub] incubator-netbeans pull request #29: [NETBEANS-54] Module Review derby

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/29


---