You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "song bruce zhang (Code Review)" <ge...@cloudera.org> on 2016/11/15 07:12:15 UTC
[kudu-CR] KUDU-1551: ignore segment when it's pre-allocated
song bruce zhang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5090
Change subject: KUDU-1551: ignore segment when it's pre-allocated
......................................................................
KUDU-1551: ignore segment when it's pre-allocated
If kudu-tserver crash after pre-allocated wal segments,
there will be no data written to it at all, it is empty.
After restart kudu-tserver, it will fail at a CHECK
when playing this empty segments.
Instead, we should ignore it when meet empty wal segments.
Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/5090/1
--
To view, visit http://gerrit.cloudera.org:8080/5090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
[kudu-CR] KUDU-1551: ignore segment when it's pre-allocated
Posted by "song bruce zhang (Code Review)" <ge...@cloudera.org>.
song bruce zhang has uploaded a new patch set (#2).
Change subject: KUDU-1551: ignore segment when it's pre-allocated
......................................................................
KUDU-1551: ignore segment when it's pre-allocated
If kudu-tserver crash after pre-allocated wal segments,
there will be no data written to it at all, it is empty.
After restart kudu-tserver, it will fail at a CHECK
when playing this empty segments.
Instead, we should ignore it when meet empty wal segments.
Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/5090/2
--
To view, visit http://gerrit.cloudera.org:8080/5090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1551: ignore segment when it's pre-allocated
Posted by "song bruce zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5090
to look at the new patch set (#3).
Change subject: KUDU-1551: ignore segment when it's pre-allocated
......................................................................
KUDU-1551: ignore segment when it's pre-allocated
If kudu-tserver crash after pre-allocated wal segments,
there will be no data written to it at all, it is empty.
After restart kudu-tserver, it will fail at a CHECK
when playing this empty segments.
Instead, we should ignore it when meet empty wal segments.
Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/5090/3
--
To view, visit http://gerrit.cloudera.org:8080/5090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1551: ignore segment when it's pre-allocated
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: KUDU-1551: ignore segment when it's pre-allocated
......................................................................
Abandoned
This was fixed by http://gerrit.cloudera.org:8080/5276
--
To view, visit http://gerrit.cloudera.org:8080/5090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4e0040f4ca9232ffabc1bbc6702e0e48e7e8a2a9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zs...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot