You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "florentos17 (via GitHub)" <gi...@apache.org> on 2024/10/16 10:22:05 UTC
[PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
florentos17 opened a new pull request, #2456:
URL: https://github.com/apache/james-project/pull/2456
for now i copy pasted the [logback-contrib repo](https://github.com/qos-ch/logback-contrib) as new module `logback-contrib`, and modified the `pom.xml` files to replace the `ch.qos.logback.contrib` with `org.apache.james`
as a first step i just wanted to succeed compiling the new module, but there is still much to do to integrate it within james project (licensing, modify imports and usages in the existing james project code, etc)
right now the module compiles but james-project as a whole does not, i am investigating it
any review very welcome !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "florentos17 (via GitHub)" <gi...@apache.org>.
florentos17 closed pull request #2456: [ISSUE-1138] Import LogBack JSON layout into tmail
URL: https://github.com/apache/james-project/pull/2456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802841193
##########
logback-contrib/mongodb/access/pom.xml:
##########
@@ -0,0 +1,44 @@
+<!--
Review Comment:
No no we are not interested in mongoDB let's drop this part logback-json contribs...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802839326
##########
logback-contrib/eclipse/pom.xml:
##########
@@ -0,0 +1,68 @@
+<!--
+
+ Copyright (C) 2016, The logback-contrib developers. All rights reserved.
+
+ This program and the accompanying materials are dual-licensed under
+ either the terms of the Eclipse Public License v1.0 as published by
+ the Eclipse Foundation
+
+ or (per the licensee's choosing)
+
+ under the terms of the GNU Lesser General Public License version 2.1
+ as published by the Free Software Foundation.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review Comment:
Drop this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802838162
##########
logback-contrib/.gitignore:
##########
@@ -0,0 +1,10 @@
+*.idea
Review Comment:
Let's remove this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802937843
##########
logback-contrib/.travis.yml:
##########
@@ -0,0 +1,4 @@
+language: java
+notifications:
+ email:
+ - notification@qos.ch
Review Comment:
Idem we are not building with travis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802840229
##########
logback-contrib/janino-fragment/README.md:
##########
@@ -0,0 +1,28 @@
+# Problem
+
+As stated in the [Logback documentation](http://logback.qos.ch/setup.html)
+conditional processing in configuration files requires the
Review Comment:
drop janino fragment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [ISSUE-1138] Import LogBack JSON layout into tmail [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2456:
URL: https://github.com/apache/james-project/pull/2456#discussion_r1802841480
##########
logback-contrib/xmpp/pom.xml:
##########
@@ -0,0 +1,36 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review Comment:
kill xmpp too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org