[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4434: [IOTDB-2036] RestApiServiceImpl access to BasicServiceProvider

[GitBox <gi...@apache.org>]

SteveYurongSu commented on a change in pull request #4434:
URL: https://github.com/apache/iotdb/pull/4434#discussion_r753059113



##########
File path: server/src/main/java/org/apache/iotdb/db/rest/impl/RestApiServiceImpl.java
##########
@@ -38,16 +31,18 @@
 import org.apache.iotdb.db.rest.model.ExecutionStatus;
 import org.apache.iotdb.db.rest.model.InsertTabletRequest;
 import org.apache.iotdb.db.rest.model.SQL;
+import org.apache.iotdb.db.service.basic.BasicServiceProvider;
 import org.apache.iotdb.rpc.TSStatusCode;
 
 import javax.ws.rs.core.Response;
 import javax.ws.rs.core.SecurityContext;
 
 public class RestApiServiceImpl extends RestApiService {
 
-  protected final IPlanExecutor executor = new PlanExecutor(); // todo cluster
   protected final Planner planner = new Planner();
 
+  public BasicServiceProvider basicServiceProvider = new BasicServiceProvider();

Review comment:
       ```suggestion
     protected final BasicServiceProvider basicServiceProvider = new BasicServiceProvider();
   ```

##########
File path: server/src/main/java/org/apache/iotdb/db/rest/impl/RestApiServiceImpl.java
##########
@@ -95,8 +90,7 @@ public Response executeQueryStatement(SQL sql, SecurityContext securityContext)
         return response;
       }
       return QueryDataSetHandler.fillDateSet(
-          QueryDataSetHandler.constructQueryDataSet(executor, physicalPlan),

Review comment:
       Remove QueryDataSetHandler if it is useless :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org