[jira] [Commented] (HADOOP-12300) BUILDING.txt instructions for skipping tests incomplete/obsolete, build can fail.

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653968#comment-14653968 ] 

Steve Loughran commented on HADOOP-12300:
-----------------------------------------

I don't think we change the instructions.

We actually like those tests to compile; even if you don't run the tests, the -test artifacts are needed downstream and so have to be published. Furthermore, the cost of a compile is low (compared to test runs), and it will catch static changes immediately.

I do think its' a local problem with your system, and that this is something you're going to need to fix -adding some details on the wiki afterwards may be useful, or we could add an IBM-platform extension to the BUILDING.TXT. But those -test artifacts are used downstream (example, base FS compatibility tests are pubished in hadoop-common-test, and picked by external FS suppliers), and publishing a hadoop build, even locally, without those artifacts, is risky.

> BUILDING.txt instructions for skipping tests incomplete/obsolete, build can fail.
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-12300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12300
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.5.0, 2.6.0
>         Environment: maven 3.2.3 +
>            Reporter: Peter D Kirchner
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Instructions currently online, and within the hadoop source tree, appear to be incomplete/obsolete for building the source.  I checked 2.5.0 and 2.6.0 .
> with "mvn install -DskipTests" my build fails on multiple hadoop src/test sub-directories with:
>    Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile (default-testCompile)...
> This compile failure may be related to my jdk/jre, but why is my build ("mvn install -DskipTests") compiling these tests?
> The pom.xml files are using the maven-compiler-plugin to compile some of the tests instead of surefire.  The maven-compiler-plugin is unaffected by -DskipTests and per maven documentation requires -Dmaven.test.skip instead, which the surefire plugin also obeys.
> Building with
> mvn install -Dmaven.test.skip
> completes in my environment.
> I suggest a "major" rating because of the impact on users of the source tarballs.  IMO the build instructions in the tarball and online (e.g. https://wiki.apache.org/hadoop/EclipseEnvironment ) should work reliably.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)