You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/15 09:12:48 UTC

[GitHub] [rocketmq] tianliuliu opened a new issue #3651: Some netty ChannelOption configuration items such as WRITE_BUFFER_WATER_MARK are not configured, which may cause memory leaks

tianliuliu opened a new issue #3651:
URL: https://github.com/apache/rocketmq/issues/3651


   int the RocketMQ remoting module
   class: 
    org.apache.rocketmq.remoting.netty.NettyRemotingClient
    org.apache.rocketmq.remoting.netty.NettyRemotingServer
   
   ```java
   this.bootstrap.group(this.eventLoopGroupWorker).channel(NioSocketChannel.class)
               .option(ChannelOption.TCP_NODELAY, true)
               .option(ChannelOption.SO_KEEPALIVE, false)
               .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, nettyClientConfig.getConnectTimeoutMillis())
               .option(ChannelOption.SO_SNDBUF, nettyClientConfig.getClientSocketSndBufSize())
               .option(ChannelOption.SO_RCVBUF, nettyClientConfig.getClientSocketRcvBufSize())
       	   // should add ChannelOption.WRITE_BUFFER_WATER_MARK config here
   ```
   
   There is no configuration item WRITE_BUFFER_WATER_MARK
   in develop branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3651: Some netty ChannelOption configuration items such as WRITE_BUFFER_WATER_MARK are not configured, which may cause memory leaks

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3651:
URL: https://github.com/apache/rocketmq/issues/3651


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3651: Some netty ChannelOption configuration items such as WRITE_BUFFER_WATER_MARK are not configured, which may cause memory leaks

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3651:
URL: https://github.com/apache/rocketmq/issues/3651#issuecomment-995806168


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org