[jira] [Commented] (JENA-1654) Use StringBuilder in LiteralImpl#asNumber

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730824#comment-16730824 ] 

ASF subversion and git services commented on JENA-1654:
-------------------------------------------------------

Commit 3faec926fca82531d0d5db6429ec94c1a33d2559 in jena's branch refs/heads/master from Bruno P. Kinoshita
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=3faec92 ]

Merge pull request #516 from kinow/use-string-builder-literalimpl

JENA-1654: Use StringBuilder in Literal#asNumber, and remove field variable

> Use StringBuilder in LiteralImpl#asNumber
> -----------------------------------------
>
>                 Key: JENA-1654
>                 URL: https://issues.apache.org/jira/browse/JENA-1654
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: Jena 3.9.0
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Trivial
>             Fix For: Jena 3.10.0
>
>
> Trivial fix, but replaces strings concatenations by a StringBuilder. Another change (which originated this work) is the removal of the unused local variable "type".
> Added a unit test for asNumber (working branch), and another when the value of the literal is not a Number. Also verified that the exception contains parts of the text expected in the error message. The test runs fine before the patch, and after the patch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)