You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/02 14:36:41 UTC
[GitHub] [incubator-iotdb] jixuan1989 opened a new pull request #1150: [IOTDB-636]Grafana connector does not use correct time unit
jixuan1989 opened a new pull request #1150:
URL: https://github.com/apache/incubator-iotdb/pull/1150
On rel/0.9, the grafana connector uses the time unit like this:
```
@Autowired
public BasicDaoImpl(JdbcTemplate jdbcTemplate) {
this.jdbcTemplate = jdbcTemplate;
Properties properties = new Properties();
String tsPrecision = properties.getProperty("timestamp_precision", "ms");
switch (tsPrecision) {
case "us":
TIMESTAMP_RADIX = 1000;
break;
case "ns":
TIMESTAMP_RADIX = 1000_000;
break;
default:
TIMESTAMP_RADIX = 1;
}
logger.info("Use timestamp precision {}", tsPrecision);
}
```
That is to say, it always is "ms"! No configuration file is read!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1150: [IOTDB-636]Grafana connector does not use correct time unit
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1150:
URL: https://github.com/apache/incubator-iotdb/pull/1150#issuecomment-622964790
> Hi, extraordinary catch. Is it also a bug in master branch ... ?
Hive fixed it in PR #1149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1150: [IOTDB-636]Grafana connector does not use correct time unit
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on pull request #1150:
URL: https://github.com/apache/incubator-iotdb/pull/1150#issuecomment-622964374
Hi, extraordinary catch. Is it also a bug in master branch ... ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org