You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/09/29 16:05:00 UTC

[jira] [Commented] (GEODE-8241) Locator does not observe locator-wait-time

    [ https://issues.apache.org/jira/browse/GEODE-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204058#comment-17204058 ] 

ASF subversion and git services commented on GEODE-8241:
--------------------------------------------------------

Commit 8fb8caa8d5b6f79c2d60e7fbe3c76709f4a81891 in geode's branch refs/heads/support/1.13 from Aaron Lindsey
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8fb8caa ]

GEODE-8241: Locator observes locator-wait-time (#5236)

In the case where a locator starts up and is unable to connect to any
other locators, it may decide to become the membership coordinator even
if locator-wait-time has not elapsed.

This change addresses this issue by requiring a locator to wait for
locator-wait-time before deciding to become the coordinator.

Co-authored-by: Aaron Lindsey <al...@vmware.com>
Co-authored-by: Vincent Ford <vf...@pivotal.io>
Co-authored-by: Bill Burcham <bb...@pivotal.io>
(cherry picked from commit 720a4caea2ddb22296aa3225fc5264d2096cdf20)


> Locator does not observe locator-wait-time
> ------------------------------------------
>
>                 Key: GEODE-8241
>                 URL: https://issues.apache.org/jira/browse/GEODE-8241
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Aaron Lindsey
>            Assignee: Aaron Lindsey
>            Priority: Major
>             Fix For: 1.14.0
>
>
> In the case where a locator starts up and is unable to connect to any other locators, it may decide to become the membership coordinator even if locator-wait-time has not elapsed.
> The following conditional from GMSJoinLeave.java causes the issue. There should be an additional check for locator-wait-time before becoming coordinator.
> {code:java}
>             if (state.joinedMembersContacted <= 0 &&
>                 (tries >= minimumRetriesBeforeBecomingCoordinator ||
>                     state.locatorsContacted >= locators.size())) {
>               synchronized (viewInstallationLock) {
>                 becomeCoordinator();
>               }
>               return true;
>             }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)