You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/09 01:01:43 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #4665: [REFACTOR]
relay::Module Def -> TypeDef
tqchen opened a new pull request #4665: [REFACTOR] relay::Module Def -> TypeDef
URL: https://github.com/apache/incubator-tvm/pull/4665
The term Def was not very clear about what is the object of interest(could be function def or type def).
Changes the term to TypeDef to be more explicit.
cc @jroesch @wweic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wweic commented on a change in pull request #4665:
[REFACTOR] relay::Module Def -> TypeDef
Posted by GitBox <gi...@apache.org>.
wweic commented on a change in pull request #4665: [REFACTOR] relay::Module Def -> TypeDef
URL: https://github.com/apache/incubator-tvm/pull/4665#discussion_r364558231
##########
File path: include/tvm/relay/module.h
##########
@@ -104,18 +104,20 @@ class ModuleNode : public RelayNode {
* \param update Controls whether you can replace a definition in the
* environment.
*/
- TVM_DLL void AddDef(const GlobalTypeVar& var, const TypeData& type, bool update = false);
+ TVM_DLL void AddTypeDef(const GlobalTypeVar& var, const TypeData& type, bool update = false);
/*!
- * \brief Add a type definition to the global environment.
- * \param var The name of the global function.
+ * \brief Add a type-level definition to the global environment.
+ * \param var The var of the global type definition.
* \param type The ADT.
* \param update Controls whether you can replace a definition in the
* environment.
*
- * It does not do type inference as AddDef does.
+ * It does not do kind checking as AddTypeDef does.
Review comment:
```suggestion
* It does not do type checking as AddTypeDef does.
```
`kind` is [type of type](https://en.wikipedia.org/wiki/Kind_(type_theory)), here should be type checking instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4665: [REFACTOR]
relay::Module Def -> TypeDef
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4665: [REFACTOR] relay::Module Def -> TypeDef
URL: https://github.com/apache/incubator-tvm/pull/4665#issuecomment-572661132
Thanks @wweic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #4665: [REFACTOR]
relay::Module Def -> TypeDef
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4665: [REFACTOR] relay::Module Def -> TypeDef
URL: https://github.com/apache/incubator-tvm/pull/4665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services