You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by jm...@apache.org on 2006/08/31 06:44:04 UTC
svn commit: r438790 - in /incubator/tuscany/java/sca/core/src:
main/java/org/apache/tuscany/core/builder/
main/java/org/apache/tuscany/core/implementation/system/component/
main/java/org/apache/tuscany/core/wire/
test/java/org/apache/tuscany/core/imple...
Author: jmarino
Date: Wed Aug 30 21:44:04 2006
New Revision: 438790
URL: http://svn.apache.org/viewvc?rev=438790&view=rev
Log:
checkstyle and pmd violation cleanup in core
Modified:
incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/implementation/system/component/SystemReferenceImpl.java
incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/wire/InboundInvocationChainImpl.java
incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/CallbackInvocationTestCase.java
incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/OneWayWireInvocationTestCase.java
incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/injection/CallbackWireObjectFactoryTestCase.java
Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java (original)
+++ incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java Wed Aug 30 21:44:04 2006
@@ -77,7 +77,6 @@
// connect inbound wires
for (InboundWire<T> inboundWire : sourceComponent.getInboundWires().values()) {
for (InboundInvocationChain chain : inboundWire.getInvocationChains().values()) {
- ServiceContract contract = inboundWire.getServiceContract();
Operation operation = chain.getOperation();
TargetInvoker invoker = sourceComponent.createTargetInvoker(null, operation);
chain.setTargetInvoker(invoker);
@@ -186,7 +185,6 @@
if (isOneWayOperation || operationHasCallback) {
invoker = component.createAsyncTargetInvoker(sourceWire, operation);
} else {
- ServiceContract inboundContract = targetWire.getServiceContract();
Operation inboundOperation = inboundChain.getOperation();
invoker = component.createTargetInvoker(null, inboundOperation);
}
@@ -228,7 +226,6 @@
if (isOneWayOperation || operationHasCallback) {
invoker = component.createAsyncTargetInvoker(sourceWire, operation);
} else {
- ServiceContract inboundContract = targetWire.getServiceContract();
Operation inboundOperation = inboundChain.getOperation();
invoker = component.createTargetInvoker(null, inboundOperation);
}
Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/implementation/system/component/SystemReferenceImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/implementation/system/component/SystemReferenceImpl.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/implementation/system/component/SystemReferenceImpl.java (original)
+++ incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/implementation/system/component/SystemReferenceImpl.java Wed Aug 30 21:44:04 2006
@@ -33,7 +33,8 @@
import org.apache.tuscany.core.implementation.system.wire.SystemOutboundWire;
/**
- * Default implementation of a reference configured with the {@link org.apache.tuscany.core.implementation.system.model.SystemBinding}
+ * Default implementation of a reference configured with the
+ * {@link org.apache.tuscany.core.implementation.system.model.SystemBinding}
*
* @version $Rev$ $Date$
*/
Modified: incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/wire/InboundInvocationChainImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/wire/InboundInvocationChainImpl.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/wire/InboundInvocationChainImpl.java (original)
+++ incubator/tuscany/java/sca/core/src/main/java/org/apache/tuscany/core/wire/InboundInvocationChainImpl.java Wed Aug 30 21:44:04 2006
@@ -18,11 +18,9 @@
*/
package org.apache.tuscany.core.wire;
-import java.lang.reflect.Method;
-
+import org.apache.tuscany.spi.model.Operation;
import org.apache.tuscany.spi.wire.InboundInvocationChain;
import org.apache.tuscany.spi.wire.MessageHandler;
-import org.apache.tuscany.spi.model.Operation;
/**
* Contains a target-side invocation chain
Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/CallbackInvocationTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/CallbackInvocationTestCase.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/CallbackInvocationTestCase.java (original)
+++ incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/CallbackInvocationTestCase.java Wed Aug 30 21:44:04 2006
@@ -30,7 +30,6 @@
import org.apache.tuscany.spi.deployer.DeploymentContext;
import org.apache.tuscany.spi.idl.InvalidServiceContractException;
import org.apache.tuscany.spi.idl.java.JavaInterfaceProcessorRegistry;
-import org.apache.tuscany.spi.idl.java.JavaServiceContract;
import org.apache.tuscany.spi.implementation.java.ConstructorDefinition;
import org.apache.tuscany.spi.implementation.java.JavaMappedProperty;
import org.apache.tuscany.spi.implementation.java.JavaMappedReference;
@@ -51,7 +50,6 @@
import org.apache.tuscany.core.implementation.java.JavaAtomicComponent;
import org.apache.tuscany.core.implementation.java.JavaComponentBuilder;
import org.apache.tuscany.core.implementation.java.JavaImplementation;
-import org.apache.tuscany.core.implementation.java.mock.components.Source;
import org.apache.tuscany.core.wire.jdk.JDKWireService;
import static org.easymock.EasyMock.createMock;
import static org.easymock.EasyMock.expectLastCall;
Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/OneWayWireInvocationTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/OneWayWireInvocationTestCase.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/OneWayWireInvocationTestCase.java (original)
+++ incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/implementation/java/integration/component/OneWayWireInvocationTestCase.java Wed Aug 30 21:44:04 2006
@@ -22,12 +22,12 @@
import java.util.Map;
import org.apache.tuscany.spi.component.WorkContext;
+import org.apache.tuscany.spi.model.Operation;
import org.apache.tuscany.spi.services.work.WorkScheduler;
import org.apache.tuscany.spi.wire.InboundInvocationChain;
import org.apache.tuscany.spi.wire.InboundWire;
import org.apache.tuscany.spi.wire.MessageImpl;
import org.apache.tuscany.spi.wire.WireService;
-import org.apache.tuscany.spi.model.Operation;
import junit.framework.TestCase;
import org.apache.tuscany.core.implementation.java.AsyncJavaTargetInvoker;
@@ -76,7 +76,7 @@
InboundWire<AsyncTarget> wire =
createServiceWire("foo", AsyncTarget.class, null, null, null);
Map<Operation, InboundInvocationChain> chains = wire.getInvocationChains();
- InboundInvocationChain chain = chains.get(wire.getServiceContract().getOperations().get("invoke"));
+ InboundInvocationChain chain = chains.get(wire.getServiceContract().getOperations().get("invoke"));
chain.setTargetInvoker(invoker);
chain.prepare();
MessageImpl msg = new MessageImpl();
Modified: incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/injection/CallbackWireObjectFactoryTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/injection/CallbackWireObjectFactoryTestCase.java?rev=438790&r1=438789&r2=438790&view=diff
==============================================================================
--- incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/injection/CallbackWireObjectFactoryTestCase.java (original)
+++ incubator/tuscany/java/sca/core/src/test/java/org/apache/tuscany/core/injection/CallbackWireObjectFactoryTestCase.java Wed Aug 30 21:44:04 2006
@@ -18,16 +18,14 @@
*/
package org.apache.tuscany.core.injection;
-import static org.easymock.EasyMock.verify;
-
import org.apache.tuscany.spi.idl.java.JavaServiceContract;
import org.apache.tuscany.spi.wire.WireService;
import junit.framework.TestCase;
-import org.easymock.EasyMock;
import static org.easymock.EasyMock.createMock;
import static org.easymock.EasyMock.expectLastCall;
import static org.easymock.EasyMock.replay;
+import static org.easymock.EasyMock.verify;
/**
* @version $Rev$ $Date$
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org