You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/01/21 19:50:00 UTC
[1/3] git commit: LocalSparkContext for MLlib
Updated Branches:
refs/heads/master 77b986f66 -> f8544981a
LocalSparkContext for MLlib
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/720836a7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/720836a7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/720836a7
Branch: refs/heads/master
Commit: 720836a76169be4f7ad010c6f6dbb54666b6aba1
Parents: fe8a354
Author: Andrew Tulloch <an...@tullo.ch>
Authored: Sun Jan 19 17:51:00 2014 +0000
Committer: Andrew Tulloch <an...@tullo.ch>
Committed: Sun Jan 19 17:51:00 2014 +0000
----------------------------------------------------------------------
.../LogisticRegressionSuite.scala | 15 ++-----------
.../mllib/classification/NaiveBayesSuite.scala | 13 ++---------
.../spark/mllib/classification/SVMSuite.scala | 15 +++----------
.../spark/mllib/clustering/KMeansSuite.scala | 15 ++-----------
.../optimization/GradientDescentSuite.scala | 13 ++---------
.../spark/mllib/recommendation/ALSSuite.scala | 14 ++----------
.../spark/mllib/regression/LassoSuite.scala | 16 ++------------
.../regression/LinearRegressionSuite.scala | 14 ++----------
.../mllib/regression/RidgeRegressionSuite.scala | 13 ++---------
.../spark/mllib/util/LocalSparkContext.scala | 23 ++++++++++++++++++++
10 files changed, 42 insertions(+), 109 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
index 02ede71..155788f 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
@@ -17,6 +17,7 @@
package org.apache.spark.mllib.classification
+import org.apache.spark.mllib.util.LocalSparkContext
import scala.util.Random
import scala.collection.JavaConversions._
@@ -66,19 +67,7 @@ object LogisticRegressionSuite {
}
-class LogisticRegressionSuite extends FunSuite with BeforeAndAfterAll with ShouldMatchers {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
-
+class LogisticRegressionSuite extends FunSuite with LocalSparkContext with ShouldMatchers {
def validatePrediction(predictions: Seq[Double], input: Seq[LabeledPoint]) {
val numOffPredictions = predictions.zip(input).count { case (prediction, expected) =>
prediction != expected.label
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
index b615f76..375196d 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
@@ -17,6 +17,7 @@
package org.apache.spark.mllib.classification
+import org.apache.spark.mllib.util.LocalSparkContext
import scala.util.Random
import org.scalatest.BeforeAndAfterAll
@@ -59,17 +60,7 @@ object NaiveBayesSuite {
}
}
-class NaiveBayesSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class NaiveBayesSuite extends FunSuite with LocalSparkContext {
def validatePrediction(predictions: Seq[Double], input: Seq[LabeledPoint]) {
val numOfPredictions = predictions.zip(input).count {
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala
index 3357b86..bc7abb5 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala
@@ -25,8 +25,9 @@ import org.scalatest.FunSuite
import org.jblas.DoubleMatrix
-import org.apache.spark.{SparkException, SparkContext}
+import org.apache.spark.SparkException
import org.apache.spark.mllib.regression._
+import org.apache.spark.mllib.util.LocalSparkContext
object SVMSuite {
@@ -58,17 +59,7 @@ object SVMSuite {
}
-class SVMSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class SVMSuite extends FunSuite with LocalSparkContext {
def validatePrediction(predictions: Seq[Double], input: Seq[LabeledPoint]) {
val numOffPredictions = predictions.zip(input).count { case (prediction, expected) =>
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/clustering/KMeansSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/clustering/KMeansSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/clustering/KMeansSuite.scala
index 73657ca..4ef1d1f 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/clustering/KMeansSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/clustering/KMeansSuite.scala
@@ -21,20 +21,9 @@ package org.apache.spark.mllib.clustering
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
-import org.apache.spark.SparkContext
+import org.apache.spark.mllib.util.LocalSparkContext
-
-class KMeansSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class KMeansSuite extends FunSuite with LocalSparkContext {
val EPSILON = 1e-4
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
index a6028a1..a453de6 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
@@ -26,6 +26,7 @@ import org.scalatest.matchers.ShouldMatchers
import org.apache.spark.SparkContext
import org.apache.spark.mllib.regression._
+import org.apache.spark.mllib.util.LocalSparkContext
object GradientDescentSuite {
@@ -62,17 +63,7 @@ object GradientDescentSuite {
}
}
-class GradientDescentSuite extends FunSuite with BeforeAndAfterAll with ShouldMatchers {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class GradientDescentSuite extends FunSuite with LocalSparkContext with ShouldMatchers {
test("Assert the loss is decreasing.") {
val nPoints = 10000
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
index 4e8dbde..28a27b1 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
@@ -23,7 +23,7 @@ import scala.util.Random
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
-import org.apache.spark.SparkContext
+import org.apache.spark.mllib.util.LocalSparkContext
import org.jblas._
@@ -73,17 +73,7 @@ object ALSSuite {
}
-class ALSSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class ALSSuite extends FunSuite with LocalSparkContext {
test("rank-1 matrices") {
testALS(50, 100, 1, 15, 0.7, 0.3)
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/regression/LassoSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/regression/LassoSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/regression/LassoSuite.scala
index b2c8df9..64e4cbb 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/regression/LassoSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/regression/LassoSuite.scala
@@ -22,21 +22,9 @@ import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
import org.apache.spark.SparkContext
-import org.apache.spark.mllib.util.LinearDataGenerator
+import org.apache.spark.mllib.util.{LinearDataGenerator, LocalSparkContext}
-
-class LassoSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class LassoSuite extends FunSuite with LocalSparkContext {
def validatePrediction(predictions: Seq[Double], input: Seq[LabeledPoint]) {
val numOffPredictions = predictions.zip(input).count { case (prediction, expected) =>
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
index 406afba..648d89b 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
@@ -21,19 +21,9 @@ import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
import org.apache.spark.SparkContext
-import org.apache.spark.mllib.util.LinearDataGenerator
+import org.apache.spark.mllib.util.{LinearDataGenerator, LocalSparkContext}
-class LinearRegressionSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
-
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class LinearRegressionSuite extends FunSuite with LocalSparkContext {
def validatePrediction(predictions: Seq[Double], input: Seq[LabeledPoint]) {
val numOffPredictions = predictions.zip(input).count { case (prediction, expected) =>
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
index 1d6a10b..7ec53eb 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
@@ -23,19 +23,10 @@ import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
import org.apache.spark.SparkContext
-import org.apache.spark.mllib.util.LinearDataGenerator
+import org.apache.spark.mllib.util.{LinearDataGenerator, LocalSparkContext}
-class RidgeRegressionSuite extends FunSuite with BeforeAndAfterAll {
- @transient private var sc: SparkContext = _
- override def beforeAll() {
- sc = new SparkContext("local", "test")
- }
-
- override def afterAll() {
- sc.stop()
- System.clearProperty("spark.driver.port")
- }
+class RidgeRegressionSuite extends FunSuite with LocalSparkContext {
def predictionError(predictions: Seq[Double], input: Seq[LabeledPoint]) = {
predictions.zip(input).map { case (prediction, expected) =>
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/720836a7/mllib/src/test/scala/org/apache/spark/mllib/util/LocalSparkContext.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/util/LocalSparkContext.scala b/mllib/src/test/scala/org/apache/spark/mllib/util/LocalSparkContext.scala
new file mode 100644
index 0000000..7d84004
--- /dev/null
+++ b/mllib/src/test/scala/org/apache/spark/mllib/util/LocalSparkContext.scala
@@ -0,0 +1,23 @@
+package org.apache.spark.mllib.util
+
+import org.scalatest.Suite
+import org.scalatest.BeforeAndAfterAll
+
+import org.apache.spark.SparkContext
+
+trait LocalSparkContext extends BeforeAndAfterAll { self: Suite =>
+ @transient var sc: SparkContext = _
+
+ override def beforeAll() {
+ sc = new SparkContext("local", "test")
+ super.beforeAll()
+ }
+
+ override def afterAll() {
+ if (sc != null) {
+ sc.stop()
+ }
+ System.clearProperty("spark.driver.port")
+ super.afterAll()
+ }
+}
[3/3] git commit: Merge pull request #469 from
ajtulloch/use-local-spark-context-in-tests-for-mllib
Posted by rx...@apache.org.
Merge pull request #469 from ajtulloch/use-local-spark-context-in-tests-for-mllib
[MLlib] Use a LocalSparkContext trait in test suites
Replaces the 9 instances of
```scala
class XXXSuite extends FunSuite with BeforeAndAfterAll {
@transient private var sc: SparkContext = _
override def beforeAll() {
sc = new SparkContext("local", "test")
}
override def afterAll() {
sc.stop()
System.clearProperty("spark.driver.port")
}
```
with
```scala
class XXXSuite extends FunSuite with LocalSparkContext {
```
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/f8544981
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/f8544981
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/f8544981
Branch: refs/heads/master
Commit: f8544981a6d05687fa950639cb1eb3c31e9b6bf5
Parents: 77b986f 3a067b4
Author: Reynold Xin <rx...@apache.org>
Authored: Tue Jan 21 10:49:54 2014 -0800
Committer: Reynold Xin <rx...@apache.org>
Committed: Tue Jan 21 10:49:54 2014 -0800
----------------------------------------------------------------------
.../LogisticRegressionSuite.scala | 15 ++-----------
.../mllib/classification/NaiveBayesSuite.scala | 14 ++----------
.../spark/mllib/classification/SVMSuite.scala | 15 +++----------
.../spark/mllib/clustering/KMeansSuite.scala | 15 ++-----------
.../optimization/GradientDescentSuite.scala | 13 ++---------
.../spark/mllib/recommendation/ALSSuite.scala | 16 +++-----------
.../spark/mllib/regression/LassoSuite.scala | 16 ++------------
.../regression/LinearRegressionSuite.scala | 15 ++-----------
.../mllib/regression/RidgeRegressionSuite.scala | 14 ++----------
.../spark/mllib/util/LocalSparkContext.scala | 23 ++++++++++++++++++++
10 files changed, 43 insertions(+), 113 deletions(-)
----------------------------------------------------------------------
[2/3] git commit: Fixed import order
Posted by rx...@apache.org.
Fixed import order
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/3a067b4a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/3a067b4a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/3a067b4a
Branch: refs/heads/master
Commit: 3a067b4a76e6363f0668b5be82ab088d6a1f79d2
Parents: 720836a
Author: Andrew Tulloch <an...@tullo.ch>
Authored: Tue Jan 21 13:34:59 2014 +0000
Committer: Andrew Tulloch <an...@tullo.ch>
Committed: Tue Jan 21 13:36:53 2014 +0000
----------------------------------------------------------------------
.../spark/mllib/classification/LogisticRegressionSuite.scala | 2 +-
.../org/apache/spark/mllib/classification/NaiveBayesSuite.scala | 3 +--
.../scala/org/apache/spark/mllib/recommendation/ALSSuite.scala | 4 ++--
.../apache/spark/mllib/regression/LinearRegressionSuite.scala | 1 -
.../org/apache/spark/mllib/regression/RidgeRegressionSuite.scala | 1 -
5 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/3a067b4a/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
index 155788f..05322b0 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
@@ -17,7 +17,6 @@
package org.apache.spark.mllib.classification
-import org.apache.spark.mllib.util.LocalSparkContext
import scala.util.Random
import scala.collection.JavaConversions._
@@ -27,6 +26,7 @@ import org.scalatest.matchers.ShouldMatchers
import org.apache.spark.SparkContext
import org.apache.spark.mllib.regression._
+import org.apache.spark.mllib.util.LocalSparkContext
object LogisticRegressionSuite {
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/3a067b4a/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
index 375196d..9dd6c79 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
@@ -17,14 +17,13 @@
package org.apache.spark.mllib.classification
-import org.apache.spark.mllib.util.LocalSparkContext
import scala.util.Random
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
import org.apache.spark.mllib.regression.LabeledPoint
-import org.apache.spark.SparkContext
+import org.apache.spark.mllib.util.LocalSparkContext
object NaiveBayesSuite {
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/3a067b4a/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
index 28a27b1..5dcec7d 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/recommendation/ALSSuite.scala
@@ -23,10 +23,10 @@ import scala.util.Random
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
-import org.apache.spark.mllib.util.LocalSparkContext
-
import org.jblas._
+import org.apache.spark.mllib.util.LocalSparkContext
+
object ALSSuite {
def generateRatingsAsJavaList(
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/3a067b4a/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
index 648d89b..281f9df 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/regression/LinearRegressionSuite.scala
@@ -20,7 +20,6 @@ package org.apache.spark.mllib.regression
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
-import org.apache.spark.SparkContext
import org.apache.spark.mllib.util.{LinearDataGenerator, LocalSparkContext}
class LinearRegressionSuite extends FunSuite with LocalSparkContext {
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/3a067b4a/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala b/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
index 7ec53eb..67dd06c 100644
--- a/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/mllib/regression/RidgeRegressionSuite.scala
@@ -22,7 +22,6 @@ import org.jblas.DoubleMatrix
import org.scalatest.BeforeAndAfterAll
import org.scalatest.FunSuite
-import org.apache.spark.SparkContext
import org.apache.spark.mllib.util.{LinearDataGenerator, LocalSparkContext}