You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/02/25 18:06:31 UTC

[GitHub] [mynewt-core] mlaz opened a new pull request #2209: Fix coding style on bsp/stm32f4discovery

mlaz opened a new pull request #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209
 
 
   Fixes coding style isses introduced on https://github.com/apache/mynewt-core/pull/2203

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz closed pull request #2209: Fix coding style on bsp/stm32f4discovery

Posted by GitBox <gi...@apache.org>.
mlaz closed pull request #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] utzig commented on issue #2209: Fix coding style on bsp/stm32f4discovery

Posted by GitBox <gi...@apache.org>.
utzig commented on issue #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209#issuecomment-591080545
 
 
   > I got an email for a failed CI test, I looked for whether there was a rule for this and I didn't find any so I assumed it should be fixed.
   
   travis-ci sends an email if `master` fails, to the person that merged the last PR. But the failure doesn't seem related to the PR changes...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on issue #2209: Fix coding style on bsp/stm32f4discovery

Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209#issuecomment-591095519
 
 
   Ok, I'm closing this PR. IMO external sources are best kept as little modified as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2209: Fix coding style on bsp/stm32f4discovery

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209#issuecomment-590991704
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/stm32f411discovery/include/bsp/stm32f4xx_hal_conf.h
   <details>
   
   ```diff
   @@ -349,7 +349,7 @@
     */
      #define assert_param(expr) ((expr) ? (void)0 : assert_failed((uint8_t *)__FILE__, __LINE__))
    /* Exported functions ------------------------------------------------------- */
   -  void assert_failed(uint8_t* file, uint32_t line);
   +void assert_failed(uint8_t * file, uint32_t line);
    #else
      #define assert_param(expr) ((void)0)
    #endif /* USE_FULL_ASSERT */
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] mlaz commented on issue #2209: Fix coding style on bsp/stm32f4discovery

Posted by GitBox <gi...@apache.org>.
mlaz commented on issue #2209: Fix coding style on bsp/stm32f4discovery
URL: https://github.com/apache/mynewt-core/pull/2209#issuecomment-591076243
 
 
   I got an email for a failed CI test, I looked for whether there was a rule for this and I didn't find any so I assumed it should be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services