You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Genmao Yu (JIRA)" <ji...@apache.org> on 2017/02/07 12:29:42 UTC

[jira] [Commented] (HADOOP-14065) AliyunOSS: oss directory filestatus should use meta time

    [ https://issues.apache.org/jira/browse/HADOOP-14065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855886#comment-15855886 ] 

Genmao Yu commented on HADOOP-14065:
------------------------------------

I think L218 has exceeded 80. 

```
+    long elapsedTime = System.currentTimeMillis()
+        - dirFileStatus.getModificationTime();
```

A better style is 

```
+    long currentTime = System.currentTimeMillis();
+    long elapsedTime = currentTime - dirFileStatus.getModificationTime();
```

> AliyunOSS: oss directory filestatus should use meta time
> --------------------------------------------------------
>
>                 Key: HADOOP-14065
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14065
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/oss
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Fei Hui
>            Assignee: Fei Hui
>         Attachments: HADOOP-14065.001.patch, HADOOP-14065.patch
>
>
> code in getFileStatus function
> else if (objectRepresentsDirectory(key, meta.getContentLength())) {
>   return new FileStatus(0, true, 1, 0, 0, qualifiedPath);
> }
> we should set right modifiedtime



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org