You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/10/17 14:22:49 UTC
Review Request 63075: RU: RU failed on "Updating configuration
sqoop-atlas-application.properties"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-22254
https://issues.apache.org/jira/browse/AMBARI-22254
Repository: ambari
Description
-------
Config types are associated with a service. As a fallback, use the enclosed config-task's service as the source of the service name.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 5c65911a9e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java d8676bdb58
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 7ad02579e8
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 9f4440f055
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d789ab45d9
ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java 44f72bd72a
Diff: https://reviews.apache.org/r/63075/diff/1/
Testing
-------
Manual. Unit tests pending.
Thanks,
Nate Cole
Re: Review Request 63075: RU: RU failed on "Updating configuration
sqoop-atlas-application.properties"
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/#review188320
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Oct. 17, 2017, 10:22 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63075/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22254
> https://issues.apache.org/jira/browse/AMBARI-22254
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Config types are associated with a service. As a fallback, use the enclosed config-task's service as the source of the service name.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 5c65911a9e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java d8676bdb58
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 7ad02579e8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 9f4440f055
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d789ab45d9
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java 44f72bd72a
>
>
> Diff: https://reviews.apache.org/r/63075/diff/1/
>
>
> Testing
> -------
>
> Manual. Unit tests pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 63075: RU: RU failed on "Updating configuration
sqoop-atlas-application.properties"
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/#review188330
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 17, 2017, 5:22 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63075/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22254
> https://issues.apache.org/jira/browse/AMBARI-22254
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Config types are associated with a service. As a fallback, use the enclosed config-task's service as the source of the service name.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 5c65911a9e
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java d8676bdb58
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java 7ad02579e8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 9f4440f055
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d789ab45d9
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java 44f72bd72a
>
>
> Diff: https://reviews.apache.org/r/63075/diff/1/
>
>
> Testing
> -------
>
> Manual. Unit tests:
>
> [WARNING] Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:01.536s
> [INFO] Finished at: Tue Oct 17 10:47:00 EDT 2017
> [INFO] Final Memory: 99M/1912M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>