You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/01/12 08:55:25 UTC
[PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
cstamas opened a new pull request, #61:
URL: https://github.com/apache/maven-install-plugin/pull/61
In general perform a cleanup of plugin, apply updates where needed. The plugin now builds against 3.9.x latest, and minimum is lifted to 3.6.3.
---
https://issues.apache.org/jira/browse/MINSTALL-197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450083695
##########
pom.xml:
##########
@@ -72,21 +72,21 @@
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
This lifts API to 3.9.6, isn't that a contradiction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450094040
##########
src/test/java/org/apache/maven/plugins/install/stubs/InstallArtifactStub.java:
##########
@@ -85,8 +85,8 @@ public void addMetadata(ArtifactMetadata metadata) {
}
}
- public Collection getMetadataList() {
- return metadataMap == null ? Collections.EMPTY_LIST : metadataMap.values();
+ public Collection<ArtifactMetadata> getMetadataList() {
+ return metadataMap == null ? Collections.emptyList() : metadataMap.values();
Review Comment:
This is a method of a stub, and test is happy, IMHO is irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450239726
##########
src/test/java/org/apache/maven/plugins/install/stubs/InstallArtifactStub.java:
##########
@@ -85,8 +85,8 @@ public void addMetadata(ArtifactMetadata metadata) {
}
}
- public Collection getMetadataList() {
- return metadataMap == null ? Collections.EMPTY_LIST : metadataMap.values();
+ public Collection<ArtifactMetadata> getMetadataList() {
+ return metadataMap == null ? Collections.emptyList() : metadataMap.values();
Review Comment:
right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450356385
##########
pom.xml:
##########
@@ -72,21 +72,21 @@
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
Let me think about that tomorrow or so...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450365089
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.2.5</maven>
Review Comment:
I think that's the one that is used by the m-plugin-p to derive the minimum required maven version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450096547
##########
pom.xml:
##########
@@ -72,21 +72,21 @@
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
Contradiction to what? The CI is updated by Slawek, so is build using 3.6.3/3.9.3 (see matrix), so min/max Maven is used, and deprecations immediately popped out (and were fixed as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450275652
##########
pom.xml:
##########
@@ -72,21 +72,21 @@
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
If we'd raise (well, lower, as this PR raises to 3.9.6) build to 3.6.3 we'd see deprecations from 2019, those from 5 years ago, no? We should build against latest, to see all current deprecations, and backward compat allows us to state (and test it) even with older maven versions, like CI shows (3.6.3 used as well). Unsure what is the question actually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450369804
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.2.5</maven>
Review Comment:
Ok, separate PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450239410
##########
pom.xml:
##########
@@ -72,21 +72,21 @@
<properties>
<javaVersion>8</javaVersion>
- <mavenVersion>3.2.5</mavenVersion>
+ <mavenVersion>3.9.6</mavenVersion>
Review Comment:
One is build, one API, no? Thought we raise at least build requirement to 3.6.3...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450367079
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.2.5</maven>
Review Comment:
I confirm that this version is the one used by m-plugin-p.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450221537
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.6.3</maven>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#issuecomment-2771878058
Resolve #247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450084824
##########
src/test/java/org/apache/maven/plugins/install/stubs/InstallArtifactStub.java:
##########
@@ -85,8 +85,8 @@ public void addMetadata(ArtifactMetadata metadata) {
}
}
- public Collection getMetadataList() {
- return metadataMap == null ? Collections.EMPTY_LIST : metadataMap.values();
+ public Collection<ArtifactMetadata> getMetadataList() {
+ return metadataMap == null ? Collections.emptyList() : metadataMap.values();
Review Comment:
Isn*t this inconsistent? One is writable, the other one not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450121790
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.6.3</maven>
Review Comment:
separate PR with separate issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINSTALL-197] Update to parent 41, cleanup [maven-install-plugin]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #61:
URL: https://github.com/apache/maven-install-plugin/pull/61#discussion_r1450361039
##########
pom.xml:
##########
@@ -46,7 +46,7 @@
</contributors>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.2.5</maven>
Review Comment:
SHouldn't that be 3.6.3 is that's the lower one we want to support and test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org