[GitHub] [spark] cloud-fan commented on a change in pull request #33993: [SPARK-36741][SQL] ArrayDistinct handle duplicated Double.NaN and Float.Nan

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #33993:
URL: https://github.com/apache/spark/pull/33993#discussion_r709247445



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -3491,17 +3521,41 @@ case class ArrayDistinct(child: Expression)
             body
           }
 
-        val processArray = withArrayNullAssignment(
+        def withNaNCheck(body: String): String = {

Review comment:
       shall we move these codegen utils to `SQLOpenHashSet` as well to reduce duplicated code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org