Re: [PR] [TIKA-4944] Extract GUIDs from onenote files [tika]

["henry-lindeman-glean (via GitHub)" <gi...@apache.org>]

henry-lindeman-glean commented on PR #3278:
URL: https://github.com/apache/tika/pull/3278#issuecomment-6044617424

   @tballison I think you meant to put [this comment](https://github.com/apache/tika/pull/3277#issuecomment-5963874799) here
   
   Anyway,
   1 - easy fix, is done
   2 - is asking me to test the link components against the test fixtures but I'm pretty sure I don't have access to the test fixtures in onedrive... it works with the files I tested with though.
   3 - the classic walker was picking up a version-history page. In test-tika-3970-dupetext.one, the extra page GUID {7B093AC2…} is only ever reached as the root of its own object space; current pages are always reached through MetaDataObjectsAboveGraphSpace. The classic walker now records page GUIDs only when they're reached through that property, so the file yields one page GUID. Turning the check off makes both new tests fail, as intended.
   4 - added
   
   sectionGuids is now sectionGuid
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org