You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Kriskras99 (via GitHub)" <gi...@apache.org> on 2026/01/23 21:38:31 UTC

[PR] chore: Move `AvroSchema` and `AvroSchemaComponent` to the `serde` module [avro-rs]

Kriskras99 opened a new pull request, #433:
URL: https://github.com/apache/avro-rs/pull/433

   After this, all the Serde stuff is in one place.
   
   Then I'll finish the documentation work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: Move `AvroSchema` and `AvroSchemaComponent` to the `serde` module [avro-rs]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #433:
URL: https://github.com/apache/avro-rs/pull/433#discussion_r2722952533


##########
avro/src/serde/derive.rs:
##########
@@ -0,0 +1,450 @@
+use crate::Schema;

Review Comment:
   Missing license



##########
avro_derive/tests/derive.rs:
##########
@@ -17,10 +17,8 @@
 
 use apache_avro::{
     Reader, Schema, Writer, from_value,
-    schema::{
-        Alias, AvroSchema, AvroSchemaComponent, EnumSchema, FixedSchema, Name, Names, Namespace,
-        RecordSchema,
-    },
+    schema::{Alias, EnumSchema, FixedSchema, Name, Names, Namespace, RecordSchema},
+    serde::{AvroSchema, AvroSchemaComponent},

Review Comment:
   Those are also exported in the root (`apache_avro::AvroSchema`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: Move `AvroSchema` and `AvroSchemaComponent` to the `serde` module [avro-rs]

Posted by "Kriskras99 (via GitHub)" <gi...@apache.org>.
Kriskras99 merged PR #433:
URL: https://github.com/apache/avro-rs/pull/433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org