You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by asdf2014 <gi...@git.apache.org> on 2017/06/20 07:18:56 UTC
[GitHub] zookeeper pull request #288: MINOR: Code refactoring for `ZK_SERVER` module
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/288
MINOR: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exception with `|` character
* Remove unnecessary boxing
* Remove unused import
* Remove unecessary `Record` instance
* Using enhanced for loop instead
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/zookeeper zk_quorum
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 9492e7aeada4d1ebe9986f1276fb97ae061c24bf
Author: asdf2014 <15...@qq.com>
Date: 2017-06-19T13:00:01Z
Fix spell issues
commit d53ffe2b0ecfa3a055b0250c2bb0c75215aab6d0
Author: asdf2014 <15...@qq.com>
Date: 2017-06-20T06:53:13Z
1. Merge exception with `|` character; 2. Remove unnecessary boxing; 3. Remove unused import
commit 14969f952af0fd1dd70cb9ed031fa7229fafcca9
Author: asdf2014 <15...@qq.com>
Date: 2017-06-20T07:14:35Z
1. Remove unecessary `Record` instance & import; 2. Using enhanced for loop instead
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #288: ZOOKEEPER-2816: Code refactoring for `ZK_SERVER...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #288: ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` modul...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/288
@hanm Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #288: ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` modul...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/288
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #288: MINOR: Code refactoring for `ZK_SERVER` module
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/288
Please create a JIRA issue for this one too - see my comment on https://github.com/apache/zookeeper/pull/283.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---