You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Eric Meyer (JIRA)" <ji...@apache.org> on 2006/02/08 03:41:57 UTC

[jira] Created: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
--------------------------------------------------------------------------------

         Key: COCOON-1771
         URL: http://issues.apache.org/jira/browse/COCOON-1771
     Project: Cocoon
        Type: Bug
  Components: Blocks: Ajax  
    Versions: 2.1.8    
    Reporter: Eric Meyer
 Attachments: cocoon-ajax.js.patch

In cocoon.ajax.Fader

  this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));

getBgColor will return '#fff'

/** Converts a "#RRGGBB" color as an array of 3 ints */
cocoon.ajax.Fader.colorToRgb = function(hex) {
    return [
        parseInt(hex.substr(1,2),16),
        parseInt(hex.substr(3,2),16),
        parseInt(hex.substr(5,2),16) ];
}

Assumes that hex starts with a '#' and has 6 additional hex characters.

The corrected implementation is

/** Converts a "#RRGGBB" color as an array of 3 ints */
cocoon.ajax.Fader.colorToRgb = function(hex) {
	var r = 255; // defaults if no match
	var g = 255;
	var b = 255;
	var i=-1;
	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
	if (colors) {
		r = parseInt(colors[++i]);
		g = parseInt(colors[++i]);
		b = parseInt(colors[++i]);
	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
		r = parseInt(colors[++i] + colors[i]);
		g = parseInt(colors[++i] + colors[i]);
		b = parseInt(colors[++i] + colors[i]);
	}
    return [r,g,b];
}

Patch attached.

Regards,
Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]

Antonio Gallardo updated COCOON-1771:
-------------------------------------


Thanks for the patch. It was applied with minor changes. Please cross check and close the bug.

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Upayavira (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365587 ] 

Upayavira commented on COCOON-1771:
-----------------------------------

No need. Just make sure that the one you use was uploaded by a known individual who clicked the "grant license" button.

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: Adding patches to Jira

Posted by Carsten Ziegeler <cz...@apache.org>.
Upayavira schrieb:
> Reinhard Poetz wrote:
>> Upayavira (JIRA) wrote:
>>
>>>     [
>>> http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365560
>>> ]
>>> Upayavira commented on COCOON-1771:
>>> -----------------------------------
>>>
>>> This patch came in as "anonymous", therefore we cannot accept it, as
>>> its provenance cannot be proven. Please resubmit it while logged into
>>> jira.
>>
>> How that? Can't we deactivate the possibity to add patches if you're not
>> logged in?
> 
> Yeah, I wondered about that too. Any jira admin able to look at it?
> 
If noone changed it in the last minutes, then I think Cocoon is
configured correctly. Only
jira users and cocoon developers are able to create new issues while all
can browse them.

Carsten
-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

Re: Adding patches to Jira

Posted by Upayavira <uv...@odoko.co.uk>.
Reinhard Poetz wrote:
> Upayavira (JIRA) wrote:
> 
>>     [
>> http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365560
>> ]
>> Upayavira commented on COCOON-1771:
>> -----------------------------------
>>
>> This patch came in as "anonymous", therefore we cannot accept it, as
>> its provenance cannot be proven. Please resubmit it while logged into
>> jira.
> 
> 
> How that? Can't we deactivate the possibity to add patches if you're not
> logged in?

Yeah, I wondered about that too. Any jira admin able to look at it?

Upayavira

Adding patches to Jira

Posted by Reinhard Poetz <re...@apache.org>.
Upayavira (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365560 ] 
> 
> Upayavira commented on COCOON-1771:
> -----------------------------------
> 
> This patch came in as "anonymous", therefore we cannot accept it, as its provenance cannot be proven. Please resubmit it while logged into jira.

How that? Can't we deactivate the possibity to add patches if you're not logged in?

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

	

	
		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

[jira] Commented: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Upayavira (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365560 ] 

Upayavira commented on COCOON-1771:
-----------------------------------

This patch came in as "anonymous", therefore we cannot accept it, as its provenance cannot be proven. Please resubmit it while logged into jira.


> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]

Antonio Gallardo reassigned COCOON-1771:
----------------------------------------

    Assign To: Antonio Gallardo

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Antonio Gallardo (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1771?page=comments#action_12365584 ] 

Antonio Gallardo commented on COCOON-1771:
------------------------------------------

Upayavira, may I remove the "anonymous" attach?

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Eric Meyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]
     
Eric Meyer closed COCOON-1771:
------------------------------

    Resolution: Fixed

Thank you, Antonio, for working with me to apply the patch.

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Eric Meyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]

Eric Meyer updated COCOON-1771:
-------------------------------

    Attachment: cocoon-ajax.js.patch

Fixed doc comment and added mechanism to pass default color in case of no matching regexp.

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Anonymous (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]

 updated COCOON-1771:
---------------------

    Attachment: cocoon-ajax.js.patch

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (COCOON-1771) cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2

Posted by "Eric Meyer (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1771?page=all ]

Eric Meyer updated COCOON-1771:
-------------------------------

    Attachment: cocoon-ajax.js.patch

Pulled in another patch that fixes a NPE in 
/**
 * System-wide handlers
 */
cocoon.ajax.BrowserUpdater.handlers

this may already be on the dev trunk, but it's not in the 2.1.8 release vesion.

> cocoon.ajax.Fader runtime error when style uses abreviated form #ccc in IE6.0sp2
> --------------------------------------------------------------------------------
>
>          Key: COCOON-1771
>          URL: http://issues.apache.org/jira/browse/COCOON-1771
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Ajax
>     Versions: 2.1.8
>     Reporter: Eric Meyer
>     Assignee: Antonio Gallardo
>  Attachments: cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch, cocoon-ajax.js.patch
>
> In cocoon.ajax.Fader
>   this.toColor = cocoon.ajax.Fader.colorToRgb(cocoon.ajax.Fader.getBgColor(this.element));
> getBgColor will return '#fff'
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
>     return [
>         parseInt(hex.substr(1,2),16),
>         parseInt(hex.substr(3,2),16),
>         parseInt(hex.substr(5,2),16) ];
> }
> Assumes that hex starts with a '#' and has 6 additional hex characters.
> The corrected implementation is
> /** Converts a "#RRGGBB" color as an array of 3 ints */
> cocoon.ajax.Fader.colorToRgb = function(hex) {
> 	var r = 255; // defaults if no match
> 	var g = 255;
> 	var b = 255;
> 	var i=-1;
> 	var colors = hex.match(/^#(\d{2})(\d{2})(\d{2})$/);
> 	if (colors) {
> 		r = parseInt(colors[++i]);
> 		g = parseInt(colors[++i]);
> 		b = parseInt(colors[++i]);
> 	} else if (colors = hex.match(/^#(\d)(\d)(\d)$/)) {
> 		r = parseInt(colors[++i] + colors[i]);
> 		g = parseInt(colors[++i] + colors[i]);
> 		b = parseInt(colors[++i] + colors[i]);
> 	}
>     return [r,g,b];
> }
> Patch attached.
> Regards,
> Eric Meyer, VP, Quoin, Inc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira