You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/10/23 18:14:10 UTC
[PR] HDDS-17146. Run each acceptance test in separate split [ozone]
adoroszlai opened a new pull request, #11722:
URL: https://github.com/apache/ozone/pull/11722
## What changes were proposed in this pull request?
Run each acceptance `test*.sh` script in separate matrix job instead of bundling them by "suite". This results in many more splits, but less time per split.
Benefits:
- reduces re-run time in case of intermittent failure
- eaiser to find failures
Also makes future improvements more easy:
- balance splits more evenly (move tests out of longest executions)
- control max. parallelism (to satisy Apache Infra policy)
- consider for selective checks (filter unaffected scripts)
Drawbacks:
- more downloads of tarball and Docker images
- more jobs/artifacts in GitHub UI
https://issues.apache.org/jira/browse/HDDS-17146
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/39987525034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11722:
URL: https://github.com/apache/ozone/pull/11722#issuecomment-6453034176
This will have conflict with #11769, so I'll update after that one is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "chihsuan (via GitHub)" <gi...@apache.org>.
chihsuan commented on code in PR #11722:
URL: https://github.com/apache/ozone/pull/11722#discussion_r4373706679
##########
dev-support/ci/acceptance_suites.sh:
##########
@@ -19,9 +19,11 @@
# shellcheck source=dev-support/ci/lib/_script_init.sh
. dev-support/ci/lib/_script_init.sh
-SUITES=$(grep --no-filename -r '^#suite:' hadoop-ozone/dist/src/main/compose \
- | sort -u | cut -f2 -d':' | grep -v 'failing')
-VERSIONS=$(grep '^old_versions=' hadoop-ozone/dist/src/main/compose/xcompat/lib.sh \
+cd hadoop-ozone/dist/src/main/compose
+SUITES=$(find . -mindepth 2 -maxdepth 2 -name 'test*.sh' | cut -c3- \
Review Comment:
I found that `ozone/test.sh` would also match `ozone/test-short-circuit.sh` in [`find_tests`](https://github.com/apache/ozone/blob/243352604abac44ea1304788730fb7bbe52102d9/hadoop-ozone/dist/src/main/compose/testlib.sh#L105), so short-circuit runs twice. Would an exact match make sense here?
##########
hadoop-ozone/dev-support/checks/acceptance.sh:
##########
@@ -56,7 +56,7 @@ create_aws_dir
mkdir -p "$REPORT_DIR"
-if [[ "${OZONE_ACCEPTANCE_SUITE}" == "s3a" ]]; then
+if [[ "${OZONE_TEST_SELECTOR}" =~ "test-s3a.sh" ]]; then
Review Comment:
nit: Just to confirm, is it expected that `repeat-acceptance.yml` with suite `s3a` no longer triggers the S3A setup? Or should we still support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11722:
URL: https://github.com/apache/ozone/pull/11722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11722:
URL: https://github.com/apache/ozone/pull/11722#issuecomment-6438073302
@peterxcli would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11722:
URL: https://github.com/apache/ozone/pull/11722#issuecomment-6411176942
Thanks @chihsuan for the review.
> are you planning to clean up the `#suite:` tags in a follow-up?
Yes, eventually :) We can drop related logic from shell scripts and workflows, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #11722:
URL: https://github.com/apache/ozone/pull/11722#discussion_r4374862394
##########
hadoop-ozone/dev-support/checks/acceptance.sh:
##########
@@ -56,7 +56,7 @@ create_aws_dir
mkdir -p "$REPORT_DIR"
-if [[ "${OZONE_ACCEPTANCE_SUITE}" == "s3a" ]]; then
+if [[ "${OZONE_TEST_SELECTOR}" =~ "test-s3a.sh" ]]; then
Review Comment:
We should still support it. Restored in 178523c28f5e1ddb8a3a30347087d8f54a67eec8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #11722:
URL: https://github.com/apache/ozone/pull/11722#discussion_r4374859445
##########
dev-support/ci/acceptance_suites.sh:
##########
@@ -19,9 +19,11 @@
# shellcheck source=dev-support/ci/lib/_script_init.sh
. dev-support/ci/lib/_script_init.sh
-SUITES=$(grep --no-filename -r '^#suite:' hadoop-ozone/dist/src/main/compose \
- | sort -u | cut -f2 -d':' | grep -v 'failing')
-VERSIONS=$(grep '^old_versions=' hadoop-ozone/dist/src/main/compose/xcompat/lib.sh \
+cd hadoop-ozone/dist/src/main/compose
+SUITES=$(find . -mindepth 2 -maxdepth 2 -name 'test*.sh' | cut -c3- \
Review Comment:
Nice catch. Addressed in 614f02bb1c5010870151fc0a9babfa95fba78d54.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17146. Run each acceptance test in separate split [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11722:
URL: https://github.com/apache/ozone/pull/11722#issuecomment-6468173862
Thanks @chihsuan for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org