You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2020/11/28 22:23:19 UTC

[Issue 128416] New: Failure due to moving absent file

https://bz.apache.org/ooo/show_bug.cgi?id=128416

          Issue ID: 128416
        Issue Type: DEFECT
           Summary: Failure due to moving absent file
           Product: Build Tools
           Version: 4.2.0-dev
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P5 (lowest)
         Component: solenv
          Assignee: issues@openoffice.apache.org
          Reporter: vorobyov.mikhail@gmail.com
  Target Milestone: ---

Remove code that uses a non-existent file

This code block tries to move $outfile while the previous code doesn't create
$outfile; only $outfile_sh and possibly $outfile_bat are created.

--- a/main/set_soenv.in
+++ b/main/set_soenv.in
@@ -2167,11 +2167,6 @@ if( defined($outfile_bat))
 # XI. Moving the output file to the build home directory.
 #--------------------------------------------------------
 #
-$tmp = $SRC_ROOT.$ds.$outfile;
-if (rename( $outfile, $tmp ) ne 1)
-{  `mv -f $outfile $tmp`;
-}
-
 $tmp = $SRC_ROOT.$ds.$outfile_sh;
 if (rename( $outfile_sh, $tmp ) ne 1)
 {  `mv -f $outfile_sh $tmp`;

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

--- Comment #2 from vorobyov.mikhail@gmail.com ---
(In reply to Matthias Seidel from comment #1)
> A "blocker" would make the program unusable or break the build process.
> Can you prove that this is the case?
> 
> Anyhow, since the code is on GitHub, could you open a Pull Request there?

I've opened a Pull Request https://github.com/apache/openoffice/pull/110.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

--- Comment #3 from Matthias Seidel <ms...@apache.org> ---
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Matthias Seidel <ms...@apache.org> ---
Merged with:

https://github.com/apache/openoffice/pull/110

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED

--- Comment #4 from Matthias Seidel <ms...@apache.org> ---
It seems that this part was removed in trunk long ago:

https://github.com/apache/openoffice/commit/25a457539c4c9ee45d9cc1446a569f5b1532c064#diff-90c5bad7c7b6152ce7d0426fcd732255bf60d14520a136753531608f7c986757

Somehow it was never backported to AOO42X.

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

vorobyov.mikhail@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Normal                      |Blocker

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Blocker                     |Normal

--- Comment #1 from Matthias Seidel <ms...@apache.org> ---
A "blocker" would make the program unusable or break the build process.
Can you prove that this is the case?

Anyhow, since the code is on GitHub, could you open a Pull Request there?

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mseidel@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128416] Failure due to moving absent file

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128416

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Issue Type|DEFECT                      |PATCH

-- 
You are receiving this mail because:
You are the assignee for the issue.