You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/05/14 17:58:26 UTC

[GitHub] [systemml] Baunsgaard commented on pull request #904: onnx-systemds implementation

Baunsgaard commented on pull request #904:
URL: https://github.com/apache/systemml/pull/904#issuecomment-628795163


   Cool many thanks, LGTM. :1st_place_medal: 
   (if i had the power i would merge it)
   
   Up for discussion in the future is still https://github.com/apache/systemml/pull/904#issuecomment-627933153
   
   Only real thing left to refine in my opinion is the Output files for validation, that i think is to much, because the tests should not reflect a specific __result__, but a certain __behavior__. But I also acknowledge this is a highly personal thing, and that some of the python tests already in does not follow this principle.
   
   @mboehm7 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org